bool_op refactor (simple version)

[SSoelvsten]

Simpler version of #624 to also close #162 . The experiments do not show there is any speed-up associated with inlining the operator. Hence, this preserves the "cleaner code" without the added code complexity.

[codecov]

Codecov Report

Attention: Patch coverage is 98.73418% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 97.257%. Comparing base (0afd369) to head (15543fc).

Files	Patch %	Lines
src/adiar/internal/algorithms/prod2.h	94.595%	2 Missing ⚠️
src/adiar/zdd/binop.cpp	98.413%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##              main      #625       +/-   ##
=============================================
+ Coverage   97.237%   97.257%   +0.019%     
=============================================
  Files           90        90               
  Lines         6371      6416       +45     
=============================================
+ Hits          6195      6240       +45     
  Misses         176       176               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

🔴 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'origin/bool_op-refactor__2' is a change in performance of -1.49% (stdev: 0.82%).

...	origin/main	origin/bool_op-refactor__2
Mean	24656.25	25024.50
Standard Deviation	88.08	204.30

Number of samples: 4

[github-actions]

🟡 Regression Test (Picotrav 'mem_ctrl')

'origin/bool_op-refactor__2' is a change in performance of -0.35% (stdev: 0.48%).

...	origin/main	origin/bool_op-refactor__2
Mean	112735.67	113132.00
Standard Deviation	301.33	547.62

Number of samples: 3

[github-actions]

🟡 Regression Test (QBF 'breakthrough/3x5_11_bwnib')

'origin/bool_op-refactor__2' is a change in performance of -0.37% (stdev: 1.12%).

...	origin/main	origin/bool_op-refactor__2
Mean	7456.75	7484.00
Standard Deviation	83.26	66.62

Number of samples: 4

[github-actions]

🟢 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'origin/bool_op-refactor__2' is a change in performance of 1.73% (stdev: 4.42%).

...	origin/main	origin/bool_op-refactor__2
Mean	11410.80	11213.40
Standard Deviation	504.87	123.30

Number of samples: 5

[github-actions]

🟢 Regression Test (QBF 'domineering/5x5_13_bwnib')

'origin/bool_op-refactor__2' is a change in performance of 1.59% (stdev: 4.97%).

...	origin/main	origin/bool_op-refactor__2
Mean	23695.40	23318.60
Standard Deviation	1177.78	57.05

Number of samples: 5

[github-actions]

🟢 Regression Test (12-Queens)

'origin/bool_op-refactor__2' is a change in performance of 3.24% (stdev: 1.29%).

...	origin/main	origin/bool_op-refactor__2
Mean	11921.40	11535.60
Standard Deviation	154.07	50.29

Number of samples: 5

[github-actions]

🟢 Regression Test (Picotrav 'adder')

'origin/bool_op-refactor__2' is a change in performance of 6.13% (stdev: 11.71%).

...	origin/main	origin/bool_op-refactor__2
Mean	9844.60	9240.70
Standard Deviation	1152.41	76.95

Number of samples: 10

[github-actions]

🟢 Regression Test (Picotrav 'arbiter')

'origin/bool_op-refactor__2' is a change in performance of 4.29% (stdev: 18.72%).

...	origin/main	origin/bool_op-refactor__2
Mean	68794.10	65840.30
Standard Deviation	12879.15	9956.96

Number of samples: 10

[github-actions]

🟢 Regression Test (14-Queens)

'origin/bool_op-refactor__2' is a change in performance of 9.03% (stdev: 16.01%).

...	origin/main	origin/bool_op-refactor__2
Mean	294621.67	268014.17
Standard Deviation	47171.24	1854.11

Number of samples: 6

[SSoelvsten]

#624 was merged after a few more optimisations were added in.