-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preliminary hack to approximate #162 optimisation inside of Quantify #618
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #618 +/- ##
=============================================
+ Coverage 97.224% 97.225% +0.001%
=============================================
Files 90 90
Lines 6341 6343 +2
=============================================
+ Hits 6165 6167 +2
Misses 176 176 ☔ View full report in Codecov by Sentry. |
🟢 Regression Test (QBF 'breakthrough/3x5_11_bwnib')'origin/internal/quantify/inline-op' is a change in performance of 1.91% (stdev: 1.63%).
Number of samples: 5 |
🟢 Regression Test (QBF 'breakthrough/3x4_19_bwnib')'origin/internal/quantify/inline-op' is a change in performance of 1.12% (stdev: 0.61%).
Number of samples: 4 |
🟢 Regression Test (QBF 'domineering/5x5_13_bwnib')'origin/internal/quantify/inline-op' is a change in performance of 3.87% (stdev: 4.82%).
Number of samples: 5 |
🟢 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')'origin/internal/quantify/inline-op' is a change in performance of 4.21% (stdev: 8.70%).
Number of samples: 10 |
🟡 Regression Test (Picotrav 'adder')'origin/internal/quantify/inline-op' is a change in performance of -0.95% (stdev: 0.97%).
Number of samples: 5 |
🟢 Regression Test (Picotrav 'arbiter')'origin/internal/quantify/inline-op' is a change in performance of 4.48% (stdev: 13.93%).
Number of samples: 10 |
🔴 Regression Test (Picotrav 'mem_ctrl')'origin/internal/quantify/inline-op' is a change in performance of -0.86% (stdev: 0.83%).
Number of samples: 3 |
Since only a single terminal ever survives, the 'resolve_terminals' is never called
In the long run, we would want to go back to the previous(ish) code but where the is-shortcutting and is-irrelevant predicates are specialised at compile-time as described in #162 .