Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preliminary hack to approximate #162 optimisation inside of Quantify #618

Merged
merged 5 commits into from
Feb 26, 2024

Conversation

SSoelvsten
Copy link
Owner

@SSoelvsten SSoelvsten commented Feb 26, 2024

In the long run, we would want to go back to the previous(ish) code but where the is-shortcutting and is-irrelevant predicates are specialised at compile-time as described in #162 .

@SSoelvsten SSoelvsten added the ✨ optimisation It's all about speed / space label Feb 26, 2024
@SSoelvsten SSoelvsten self-assigned this Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 96.84211% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 97.225%. Comparing base (acd18b0) to head (d8a9cef).

Files Patch % Lines
src/adiar/internal/algorithms/quantify.h 94.737% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##              main      #618       +/-   ##
=============================================
+ Coverage   97.224%   97.225%   +0.001%     
=============================================
  Files           90        90               
  Lines         6341      6343        +2     
=============================================
+ Hits          6165      6167        +2     
  Misses         176       176               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 26, 2024

🟢 Regression Test (QBF 'breakthrough/3x5_11_bwnib')

'origin/internal/quantify/inline-op' is a change in performance of 1.91% (stdev: 1.63%).

... origin/main origin/internal/quantify/inline-op
Mean 7702.60 7555.60
Standard Deviation 125.28 49.59

Number of samples: 5

Copy link

github-actions bot commented Feb 26, 2024

🟢 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'origin/internal/quantify/inline-op' is a change in performance of 1.12% (stdev: 0.61%).

... origin/main origin/internal/quantify/inline-op
Mean 25198.25 24916.50
Standard Deviation 153.04 123.07

Number of samples: 4

Copy link

github-actions bot commented Feb 26, 2024

🟢 Regression Test (QBF 'domineering/5x5_13_bwnib')

'origin/internal/quantify/inline-op' is a change in performance of 3.87% (stdev: 4.82%).

... origin/main origin/internal/quantify/inline-op
Mean 23128.80 22234.20
Standard Deviation 1115.40 180.91

Number of samples: 5

Copy link

github-actions bot commented Feb 26, 2024

🟢 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'origin/internal/quantify/inline-op' is a change in performance of 4.21% (stdev: 8.70%).

... origin/main origin/internal/quantify/inline-op
Mean 28295.30 27103.30
Standard Deviation 2462.99 219.75

Number of samples: 10

Copy link

github-actions bot commented Feb 26, 2024

🟡 Regression Test (Picotrav 'adder')

'origin/internal/quantify/inline-op' is a change in performance of -0.95% (stdev: 0.97%).

... origin/main origin/internal/quantify/inline-op
Mean 9224.20 9312.00
Standard Deviation 89.09 84.66

Number of samples: 5

Copy link

github-actions bot commented Feb 26, 2024

🟢 Regression Test (Picotrav 'arbiter')

'origin/internal/quantify/inline-op' is a change in performance of 4.48% (stdev: 13.93%).

... origin/main origin/internal/quantify/inline-op
Mean 66048.70 63088.70
Standard Deviation 9200.86 550.28

Number of samples: 10

Copy link

github-actions bot commented Feb 26, 2024

🔴 Regression Test (Picotrav 'mem_ctrl')

'origin/internal/quantify/inline-op' is a change in performance of -0.86% (stdev: 0.83%).

... origin/main origin/internal/quantify/inline-op
Mean 112114.00 113072.67
Standard Deviation 644.89 935.36

Number of samples: 3

@SSoelvsten SSoelvsten merged commit fc67136 into main Feb 26, 2024
49 of 54 checks passed
@SSoelvsten SSoelvsten deleted the internal/quantify/inline-op branch February 26, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ optimisation It's all about speed / space
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant