Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal/count refactor #575

Merged
merged 6 commits into from
Nov 15, 2023
Merged

Internal/count refactor #575

merged 6 commits into from
Nov 15, 2023

Conversation

SSoelvsten
Copy link
Owner

Count algorithm for #416 .

@SSoelvsten SSoelvsten added the ✨ code quality Uncle Bob would be proud label Nov 15, 2023
@SSoelvsten SSoelvsten self-assigned this Nov 15, 2023
@SSoelvsten SSoelvsten added the 📁 internal This is where the ✨magic✨happens label Nov 15, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4d8f824) 96.916% compared to head (2421d46) 96.933%.

Additional details and impacted files
@@              Coverage Diff              @@
##              main      #575       +/-   ##
=============================================
+ Coverage   96.916%   96.933%   +0.018%     
=============================================
  Files           83        83               
  Lines         5836      5837        +1     
=============================================
+ Hits          5656      5658        +2     
+ Misses         180       179        -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SSoelvsten SSoelvsten merged commit 9ad35ef into main Nov 15, 2023
3 checks passed
@SSoelvsten SSoelvsten deleted the internal/count-refactor branch November 15, 2023 19:54
Copy link

Benchmark Report 🟢

origin/internal/count-refactor is a regression of 0.35% (compared to origin/main).

Minimum running time (s) for 9-Queens:

origin/main origin/internal/count-refactor
0.23 0.23
Raw Data

Running times (s) for 9-Queens:

origin/main origin/internal/count-refactor
0.23 0.23
0.23 0.23
0.24 0.23
0.23 0.24
0.24 0.23
0.23 0.23
0.23 0.23
0.23 0.23
0.24 0.23
0.24 0.24
0.26 0.23
0.24 0.24
0.24 0.23
0.24 0.24
0.23 0.24
0.23 0.24

Copy link

Benchmark Report 🟢

origin/internal/count-refactor is an improvement of 0.09% (compared to origin/main).

Minimum running time (s) for 12-Queens:

origin/main origin/internal/count-refactor
11.40 11.39
Raw Data

Running times (s) for 12-Queens:

origin/main origin/internal/count-refactor
11.54 11.45
11.43 11.39
11.43 11.56
11.50 11.50
11.47 11.57
11.45 11.45
11.57 11.40
11.53 11.43
11.48 11.50
11.40 11.41
11.57 11.47
11.47 11.40
11.43 11.43
11.56 11.53
11.42 11.42
11.64 11.44

Copy link

Benchmark Report 🟢

origin/internal/count-refactor is an improvement of 0.28% (compared to origin/main).

Minimum running time (s) for 14-Queens:

origin/main origin/internal/count-refactor
270.79 270.03
Raw Data

Running times (s) for 14-Queens:

origin/main origin/internal/count-refactor
378.50 271.33
270.79 271.50
270.84 270.03
271.83 270.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ code quality Uncle Bob would be proud 📁 internal This is where the ✨magic✨happens
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant