Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad index in 'zdd_disjoint' path pruning #568

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

SSoelvsten
Copy link
Owner

@SSoelvsten SSoelvsten commented Nov 5, 2023

Closes #471 .

@SSoelvsten SSoelvsten added ✨ optimisation It's all about speed / space 📁 zdd Zero-suppressed Decision Diagrams labels Nov 5, 2023
@SSoelvsten SSoelvsten self-assigned this Nov 5, 2023
Copy link

github-actions bot commented Nov 5, 2023

Benchmark Report 🟢

origin/zdd/disjoint/missing-unit-test is an improvement of 2.76% (compared to origin/main).

Minimum running time (s) for 9-Queens:

origin/main origin/zdd/disjoint/missing-unit-test
0.26 0.25
Raw Data

Running times (s) for 9-Queens:

origin/main origin/zdd/disjoint/missing-unit-test
0.26 0.26
0.26 0.31
0.26 0.26
0.26 0.31
0.26 0.26
0.27 0.26
0.26 0.26
0.26 0.26
0.26 0.26
0.26 0.31
0.26 0.26
0.26 0.26
0.26 0.31
0.26 0.25
0.26 0.26
0.26 0.25

Copy link

github-actions bot commented Nov 5, 2023

Benchmark Report 🟢

origin/zdd/disjoint/missing-unit-test is a regression of 0.03% (compared to origin/main).

Minimum running time (s) for 12-Queens:

origin/main origin/zdd/disjoint/missing-unit-test
11.43 11.43
Raw Data

Running times (s) for 12-Queens:

origin/main origin/zdd/disjoint/missing-unit-test
11.43 11.57
11.58 11.53
11.48 11.51
11.82 11.46
11.43 11.60
11.49 11.49
11.45 11.47
11.49 11.54
11.51 11.43
11.50 11.50
11.51 11.43
11.46 11.46
11.44 11.47
11.49 11.47
11.50 11.53
11.51 11.46

This mistake was introduced in the refactoring of 18c3619 . As such, it does not
produce incorrect answers. But, it does make it slower that it truly needs to
be.
@SSoelvsten SSoelvsten force-pushed the zdd/disjoint/missing-unit-test branch from b7f165c to fc5c6ff Compare November 5, 2023 07:13
@SSoelvsten SSoelvsten merged commit 407bf72 into main Nov 5, 2023
41 of 48 checks passed
@SSoelvsten SSoelvsten deleted the zdd/disjoint/missing-unit-test branch November 5, 2023 07:13
Copy link

github-actions bot commented Nov 5, 2023

Benchmark Report 🟢

origin/zdd/disjoint/missing-unit-test is an improvement of 1.00% (compared to origin/main).

Minimum running time (s) for 9-Queens:

origin/main origin/zdd/disjoint/missing-unit-test
0.31 0.31
Raw Data

Running times (s) for 9-Queens:

origin/main origin/zdd/disjoint/missing-unit-test
0.34 0.31
0.34 0.34
0.35 0.31
0.35 0.36
0.34 0.34
0.33 0.36
0.34 0.34
0.33 0.39
0.35 0.33
0.35 0.33
0.31 0.32
0.32 0.35
0.36 0.38
0.33 0.37
0.34 0.31
0.34 0.42

Copy link

github-actions bot commented Nov 5, 2023

Benchmark Report 🟢

origin/zdd/disjoint/missing-unit-test is a regression of 0.38% (compared to origin/main).

Minimum running time (s) for 12-Queens:

origin/main origin/zdd/disjoint/missing-unit-test
14.86 14.92
Raw Data

Running times (s) for 12-Queens:

origin/main origin/zdd/disjoint/missing-unit-test
14.86 14.96
14.95 14.95
14.92 14.94
15.61 14.96
14.97 14.92
14.94 15.01
14.94 14.94
14.97 14.94
14.92 14.96
14.97 15.03
14.97 14.99
15.06 15.02
14.97 15.01
15.04 15.01
14.97 14.98
14.97 14.98

Copy link

github-actions bot commented Nov 5, 2023

Benchmark Report 🟢

origin/zdd/disjoint/missing-unit-test is an improvement of 0.35% (compared to origin/main).

Minimum running time (s) for 14-Queens:

origin/main origin/zdd/disjoint/missing-unit-test
269.61 268.67
Raw Data

Running times (s) for 14-Queens:

origin/main origin/zdd/disjoint/missing-unit-test
374.38 271.92
269.61 268.67
270.10 270.20
269.77 269.44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ optimisation It's all about speed / space 📁 zdd Zero-suppressed Decision Diagrams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Unit Test Coverage: zdd_disjoint
1 participant