Feature / Generators and Iterators (instad of Files) in API #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an extremely niche builder feature. I would rather revert this commit and fix everything, when there is a need for it.
SSoelvsten
added
✨ feature
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #537 +/- ##
=============================================
- Coverage 97.124% 97.101% -0.023%
=============================================
Files 82 81 -1
Lines 5632 5588 -44
=============================================
- Hits 5470 5426 -44
Misses 162 162
☔ View full report in Codecov by Sentry. |
This way, the end user can plug in their own data structures without any need to spend linear time and I/Os on first writing it to a file. Somehow the user is able to compute these values, so they may as well do so on-the-fly as our algorithms need it
Since we (1) may have to read the input in reverse or (2) we need to retrieve from two different places (once for the priority queue and once for the algorithm), we still copy the entire input into a file. Hopefully, we can find a better solution some other day.
SSoelvsten
force-pushed
the
feature/iterators-not-files-in-api
branch
from
855b67c to
125ebba
Compare
|
System tests are breaking, because of the Adiar adapter uses the broken part of the API (specifically, it uses |
These are mere aliases for 'bdd_true()' and 'bdd_false()', but we add these to create consistency with the to-be added ZDD versions
This specifically is to address the suddenly missing feature with the prior breaking change to 'zdd_powerset(...)' not being able to take the global domain as an input. This is (arguably?) an even prettier solution.
SSoelvsten
force-pushed
the
feature/iterators-not-files-in-api
branch
from
125ebba to
6477cd1
Compare
Benchmark Report 🟢
Minimum running time (s) for 9-Queens:
|
Benchmark Report 🟢
Minimum running time (s) for 12-Queens:
|
Benchmark Report 🟢
Minimum running time (s) for 14-Queens:
|
7 tasks
SSoelvsten
modified the milestones:
v2.0 : Multi-variable Quantification,
v2.0 : API Revamp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #532 by removing any occurence of
adiar::shared_file<label_t>in the public API. This also removesbdd_counterandzdd_sized_setuntil I have found a way to implement them anew.