Minor code cleanup in Quantify and Replace algorithms

SSoelvsten · Jun 14, 2024 · 72e2775 · 72e2775
1 parent 471e770
commit 72e2775
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/adiar/internal/algorithms/quantify.h b/src/adiar/internal/algorithms/quantify.h
@@ -1066,7 +1066,7 @@ namespace adiar::internal
     ////////////////////////////////////////////////////////////////////////////////////////////////
     static constexpr bool partial_quantification = false;
 
-    // bool has_sweep(typename Policy::label_type) const;
+    // bool has_sweep(const typename Policy::label_type x) const;
 
     ////////////////////////////////////////////////////////////////////////////////////////////////
     /// \brief What the labels should be mapped to (themselves).
@@ -1348,12 +1348,12 @@ namespace adiar::internal
 
   public:
     ////////////////////////////////////////////////////////////////////////////////////////////////
-    /// \brief Whether the generator wants to sweep on the given level.
+    /// \brief Whether the predicate wants to sweep on the given level.
     ////////////////////////////////////////////////////////////////////////////////////////////////
     bool
-    has_sweep(node::pointer_type::label_type l)
+    has_sweep(const typename Policy::label_type x)
     {
-      return _pred(l) == Policy::quantify_onset;
+      return _pred(x) == Policy::quantify_onset;
     }
   };
 
@@ -1694,9 +1694,9 @@ namespace adiar::internal
     /// \brief Whether the generator wants to do a Nested Sweep on the given level.
     ////////////////////////////////////////////////////////////////////////////////////////////////
     bool
-    has_sweep(const typename Policy::label_type l)
+    has_sweep(const typename Policy::label_type x)
     {
-      return l == next_level(l) ? Policy::quantify_onset : !Policy::quantify_onset;
+      return x == next_level(x) ? Policy::quantify_onset : !Policy::quantify_onset;
     }
 
   private:

diff --git a/src/adiar/internal/algorithms/replace.h b/src/adiar/internal/algorithms/replace.h
@@ -213,7 +213,7 @@ namespace adiar::internal
 #endif
       return dd;
     }
-    adiar_unreachable();
+    adiar_unreachable(); // LCOV_EXCL_LINE
   }
 
   //////////////////////////////////////////////////////////////////////////////////////////////////