Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: ldap log in grace period automation #7722

Closed
wants to merge 1 commit into from

Conversation

shridhargadekar
Copy link
Contributor

@shridhargadekar shridhargadekar commented Nov 26, 2024

Backporting the automation of RHEL-55993.
Picked from deefe9a

@alexey-tikhonov alexey-tikhonov added the no-backport This should go to target branch only. label Nov 26, 2024
@alexey-tikhonov
Copy link
Member

Please use git cherry-pick -x to add a reference to original commit automatically.

@shridhargadekar
Copy link
Contributor Author

shridhargadekar commented Nov 26, 2024

git cherry-pick -x is adding unwarranted changes/conflicts.

@alexey-tikhonov
Copy link
Member

Then please add a reference to sssd-2-9 commit manually to the commit message

@shridhargadekar
Copy link
Contributor Author

@shridhargadekar shridhargadekar force-pushed the ldap_login_grace branch 2 times, most recently from 5d4fef2 to ed3fd7b Compare November 26, 2024 14:23
Copy link
Contributor

@thalman thalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch is well cherry picked, but not the commit message.

Please make it more accurate - copy it from the referenced commit or write it on your own but import of time module is wrong description.

Please Include the reference as Alexey suggested.

@madhuriupadhye
Copy link
Contributor

Also, I see @pytest.mark.parametrize decorator new parameter as a exop_force , can you add it.

reference commit number 7184541
ldap: add 'exop_force' value for ldap_pwmodify_mode

In case the LDAP server allows to run the extended operation to change a
password even if an authenticated bind fails due to missing grace logins
the new option 'exop_force' can be used to run the extended operation to
change the password anyways.

:config: Added `exop_force` value for configuration option
  `ldap_pwmodify_mode`. This can be used to force a password change even
  if no grace logins are left. Depending on the configuration of the
  LDAP server it might be expected that the password change will fail.
@alexey-tikhonov
Copy link
Member

alexey-tikhonov commented Nov 27, 2024

Just git cherry-pick -x and then git commit --amend to add "import time".

Or what are "unwarranted changes/conflicts"?

@shridhargadekar
Copy link
Contributor Author

Just git cherry-pick -x and then git commit --amend to add "import time".

Or what are "unwarranted changes/conflicts"?

Check 2-9 branch automation of 1507035 vs 2-9-4 automation of 1507035. Mojority of doc-strings, testcases metadata have been updated.

Now I can cherry pick the commit from master or 2-9 branch to the 2-9-4, modify the testcode as per existing 2-9-4 testcases.

@shridhargadekar shridhargadekar marked this pull request as draft November 28, 2024 10:23
@thalman
Copy link
Contributor

thalman commented Dec 6, 2024

I'm not sure about status of this PR. It is in draft state but it has waiting for review label.

If it is waiting for review then it still has wrong message from different commit

Please rebase it and reword it like this:

tests: add 'expo_force' tests

The new value for the ldap_pwmodify_mode option 'exop_force' is added to
existing test. A new test to illustrate the different behavior of 'exop'
and 'exop_force' is added.

(cherry picked from commit deefe9ad82e8e0057aa77ea5be60a86d223900da)

@shridhargadekar
Copy link
Contributor Author

closing this one, as #7744 has been raised from a cherry-pick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport This should go to target branch only. Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants