Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: authentication, adding override_homedir tests #7682

Closed
wants to merge 2 commits into from
Closed

tests: authentication, adding override_homedir tests #7682

wants to merge 2 commits into from

Conversation

danlavu
Copy link

@danlavu danlavu commented Nov 4, 2024

  • moving ad specific test out of authentication and to it's own file

@danlavu danlavu added the Tests label Nov 4, 2024
@danlavu danlavu mentioned this pull request Nov 4, 2024
Closed
@danlavu danlavu force-pushed the test-generic-authentication branch from 69ddac9 to 1992951 Compare November 4, 2024 23:49
@danlavu danlavu force-pushed the test-generic-authentication branch from 1992951 to 4153ae3 Compare November 5, 2024 03:53
jakub-vavra-cz
jakub-vavra-cz requested changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments

src/tests/system/tests/test_ad.py Show resolved Hide resolved
src/tests/system/tests/test_authentication.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_authentication.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_authentication.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_authentication.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_ad.py Show resolved Hide resolved
src/tests/system/tests/test_authentication.py Outdated Show resolved Hide resolved
@danlavu danlavu force-pushed the test-generic-authentication branch from 4153ae3 to 9d8dd09 Compare November 5, 2024 15:51
@danlavu
Copy link
Author

danlavu commented Nov 5, 2024

The tests are going to fail, now this PR depends on SSSD/sssd-test-framework#136

jakub-vavra-cz
jakub-vavra-cz approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@danlavu danlavu mentioned this pull request Nov 13, 2024
Merged
@danlavu danlavu force-pushed the test-generic-authentication branch 2 times, most recently from 663a844 to cbf6617 Compare November 21, 2024 21:47
@danlavu danlavu force-pushed the test-generic-authentication branch 2 times, most recently from 23f3645 to 64d2005 Compare December 5, 2024 02:17
pbrezina
pbrezina approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@pbrezina pbrezina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is finally green \o/. c10s failure is not related.

@danlavu
Copy link
Author

danlavu commented Dec 5, 2024

Failure is not related to the test.

@alexey-tikhonov
Copy link
Member

alexey-tikhonov commented Dec 10, 2024 •
edited
Loading

@danlavu, please rebase.

@alexey-tikhonov alexey-tikhonov removed the Ready to push Ready to push label Dec 10, 2024
@danlavu danlavu force-pushed the test-generic-authentication branch from 64d2005 to a0f698c Compare December 10, 2024 15:02
@alexey-tikhonov alexey-tikhonov added Ready to push Ready to push and removed Ready to push Ready to push labels Dec 11, 2024
@alexey-tikhonov alexey-tikhonov added Ready to push Ready to push and removed branch: sssd-2-9 labels Dec 11, 2024
@alexey-tikhonov
Copy link
Member

Pushed PR: #7682

  • master
    • 132d208 - tests: adding override_homedir test
    • b060ed5 - tests: moved ad specific authentication test and created test_ad.py
  • sssd-2-10
    • 7fa0591 - tests: adding override_homedir test
    • 5bac96b - tests: moved ad specific authentication test and created test_ad.py

@alexey-tikhonov
Copy link
Member

@danlavu, patches didn't apply to sssd-2-9
Please open explicit backport PR if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakub-vavra-cz jakub-vavra-cz jakub-vavra-cz approved these changes

@pbrezina pbrezina pbrezina approved these changes

Assignees

@pbrezina pbrezina

@jakub-vavra-cz jakub-vavra-cz

Labels
branch: sssd-2-10 Pushed Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danlavu @alexey-tikhonov @pbrezina @jakub-vavra-cz