Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conf: remove unused reconnection_retries #7632

Closed
wants to merge 1 commit into from

Conversation

pbrezina
Copy link
Member

@pbrezina pbrezina commented Oct 3, 2024

This option is no longer used since 9f8551a

Resolves: #7502

@alexey-tikhonov
Copy link
Member

Code looks good to me.
Could you please add :config: release note to the commit message?

This option is no longer used since 9f8551a

Resolves: SSSD#7502

:config: Option `reconnection_retries` was removed since it is no longer
  used. SSSD switch to a new architecte of internal IPC between SSSD
  processes where responders do not connect to backend anymore and
  therefore this option is no longer used.
@pbrezina pbrezina force-pushed the reconnection_retries branch from 02f5a6b to 3350a42 Compare October 4, 2024 11:17
@pbrezina
Copy link
Member Author

pbrezina commented Oct 4, 2024

Done.

@alexey-tikhonov
Copy link
Member

Thank you, ACK.

Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I'm not setting the Accept label because CI is failing and I don't have enough time right now to investigate it. Feel free to add the label once you are able to process the failures.

@alexey-tikhonov
Copy link
Member

Pushed PR: #7632

  • master
    • 8be2172 - conf: remove unused reconnection_retries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport This should go to target branch only. Pushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove leftovers of old reconnection code
3 participants