Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Passkey test cases with diffferent auth_methods #7611

Closed
wants to merge 1 commit into from
Closed

Test: Passkey test cases with diffferent auth_methods #7611

wants to merge 1 commit into from

Conversation

madhuriupadhye
Copy link
Contributor

@madhuriupadhye madhuriupadhye commented Sep 20, 2024 •
edited
Loading

Added following test cases

  1. Check authentication of user with IPA server when
    no pin set for the Passkey.
  2. Check authentication of user with updated prompting
    options
  3. Check password authentication of user with IPA server
    when sssd fall back to password authentication

@madhuriupadhye madhuriupadhye marked this pull request as draft September 20, 2024 11:30
@madhuriupadhye madhuriupadhye force-pushed the auth_method branch 5 times, most recently from b72564c to 2078277 Compare September 23, 2024 07:24
@madhuriupadhye madhuriupadhye marked this pull request as ready for review September 24, 2024 12:20
@madhuriupadhye madhuriupadhye added Blocked backport-to-stable passkey Issues and PRs related to 'passkey' feature labels Sep 26, 2024
spoore1
spoore1 reviewed Sep 26, 2024
View reviewed changes
Copy link
Contributor

@spoore1 spoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good. Just some small wording updates would help I think. Suggestions in line.

src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
@justin-stephenson justin-stephenson self-assigned this Sep 26, 2024
@madhuriupadhye madhuriupadhye force-pushed the auth_method branch 3 times, most recently from ebbb2e0 to 48f491b Compare September 30, 2024 13:09
spoore1
spoore1 approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@spoore1 spoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justin-stephenson
Copy link
Contributor 

 tests/test_passkey.py:778: error: Argument "auth_method" to "passkey_with_output" of "SUAuthenticationUtils" has incompatible type "str"; expected "PasskeyAuthenticationUseCases"  [arg-type]
tests/test_passkey.py:831: error: Argument "auth_method" to "passkey_with_output" of "SUAuthenticationUtils" has incompatible type "str"; expected "PasskeyAuthenticationUseCases"  [arg-type]
tests/test_passkey.py:877: error: Argument "auth_method" to "passkey_with_output" of "SUAuthenticationUtils" has incompatible type "str"; expected "PasskeyAuthenticationUseCases"  [arg-type]

thalman
thalman approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@thalman thalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@madhuriupadhye
Test: Passkey test cases with diffferent auth_methods
fcc1ea9 
Added following test cases
1. Check authentication of user with IPA server when
no pin set for the Passkey.
2. Check authentication of user with updated prompting
options
3. Check password authentication of user with IPA server
when sssd fall back to password authentication

Signed-off-by: Madhuri Upadhye <[email protected]>
justin-stephenson
justin-stephenson approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@justin-stephenson justin-stephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, thank you.

spoore1
spoore1 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@spoore1 spoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexey-tikhonov
Copy link
Member

@madhuriupadhye,

Conflict in sssd-2-9

@alexey-tikhonov
Copy link
Member

Pushed PR: #7611

  • master
    • 94e47c5 - Test: Passkey test cases with diffferent auth_methods
  • sssd-2-10
    • 2eec5eb - Test: Passkey test cases with diffferent auth_methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin-stephenson justin-stephenson justin-stephenson approved these changes

@spoore1 spoore1 spoore1 approved these changes

@thalman thalman thalman approved these changes

Assignees

@thalman thalman

@spoore1 spoore1

@justin-stephenson justin-stephenson

Labels
branch: sssd-2-10 passkey Issues and PRs related to 'passkey' feature Pushed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@madhuriupadhye @justin-stephenson @alexey-tikhonov @thalman @spoore1