Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: removing intg/test_files_ops.py #7579

Closed
wants to merge 1 commit into from
Closed

tests: removing intg/test_files_ops.py #7579

wants to merge 1 commit into from

Conversation

danlavu
Copy link

@danlavu danlavu commented Sep 9, 2024

These tests the user/remove functions and can be dropped.

thalman

This comment was marked as outdated.

Sign in to view

thalman
thalman requested changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@thalman thalman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, but there is an error connected with this PR:

make[2]: *** No rule to make target 'test_files_ops.py', needed by 'all-am'. Stop.

You can see this in ci/build

@aborah-sudo aborah-sudo self-requested a review September 11, 2024 10:47
tests: removing intg/test_files_ops.py
65e8102 
These tests the user/remove functions and can be dropped.
@danlavu danlavu force-pushed the tests-rm-intg-files_ops branch from 48063c1 to 65e8102 Compare September 12, 2024 15:58
thalman
thalman approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@thalman thalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, ACK

@alexey-tikhonov alexey-tikhonov added the Ready to push Ready to push label Sep 17, 2024
@alexey-tikhonov
Copy link
Member

Pushed PR: #7579

  • master
    • e442fdf - tests: removing intg/test_files_ops.py
  • sssd-2-9
    • 01dea87 - tests: removing intg/test_files_ops.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aborah-sudo aborah-sudo aborah-sudo approved these changes

@thalman thalman thalman approved these changes

Assignees

@thalman thalman

@aborah-sudo aborah-sudo

Labels
Pushed Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danlavu @alexey-tikhonov @thalman @aborah-sudo