tests: removing intg/test_confdb.py

[danlavu]

Dropping these tests as they do not have much impact.

[ikerexxe]

I fail to see where the removed these are covered in test_sssctl.py. I'm not a expecting a 100% match, but something similar at least. Dan can you point me one of the test cases that covers these scenarios?

[shridhargadekar]

Could you share the coverage in new testframework?

[danlavu]

@ikerexxe

The description is inaccurate, so these are the three tests, the first two are tested just by running tests, the last one I felt we can drop these tests as they really do not add much value.

test_domains__enabled - Test that SSSD starts with explicitly configured domain. missing domain=test
test_domains__domains - Test that SSSD starts without domains option. enabled=true as a default value
test_domains__empty - Test that SSSD fails without any domain enabled enabled=false*

We can add them still, these would be marked integration and set to a low priority? What would you prefer?

[danlavu]

I went ahead and quickly wrote the tests and added them to test_files.py. They don't offer much.

[ikerexxe]

Now you can understand our confusion when we were reviewing the PR. I'm fine with both transforming the tests and with removing them.

As a side note, if you want to remove test_confdb.py, then you'll need to remove its reference from src/tests/intg/Makefile.am. I think that's the only place where the file is mentioned in our build infrastructure. That should make CI happy.

[danlavu]

@ikerexxe I understand entirely, and I'm sorry for generalizing; there are many things to track as we're doing this test transformation.

I updated the Makefile on all my PRs. Thank you.

[ikerexxe]

LGTM! Thank you for taking care of it

[alexey-tikhonov]

Pushed PR: #7578

• master
  • 97571b1 - tests: removing intg/test_confdb.py
• sssd-2-9
  • 838ee2f - tests: removing intg/test_confdb.py