Remove multihost basic tests #7562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the watched file was a symbolic link or was a relative path, the calback was not executed because the filename comparison was wrongly considering the files to be different. The solution is to normalize the filenames before comparing them. This cannot be easily done at setup because the file could not exist at that moment. The test was adapted to check this situation. Resolves: SSSD#6718 Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Pavel Březina <[email protected]> (cherry picked from commit b2a4ff2)
Use /* */ instead of //. Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Pavel Březina <[email protected]> (cherry picked from commit 90c5490)
When checking if the input group-name is the original name from AD or an overwritten one the comparison is currently done case sensitive. Since AD handles names case-insensitive and hence SSSD should do this as well this comparison might cause issues. The patch replace the case sensitive comparison with a comparison with respects the case_sensitive of the domain the object is coming from. Resolves: SSSD#6720 Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Iker Pedrosa <[email protected]> (cherry picked from commit 01d0279)
Signed-off-by: Iker Pedrosa <[email protected]> Reviewed-by: Andre Boscatto <[email protected]> Reviewed-by: Justin Stephenson <[email protected]> Reviewed-by: Pavel Březina <[email protected]> (cherry picked from commit 906a677)
When 'make' runs using multiple threads it can build several man pages in parallel, executing the same '.5.xml.5:' rule. This can result in a race condition where multiple threads access the same 'sssd_user_name.include' file. To avoid this make 'sssd_user_name.include' file a rule dependency. But "Suffix rules cannot have any prerequisites of their own", and suffix rules are obsolete anyway, so change it to pattern rules. Reviewed-by: Alejandro López <[email protected]> Reviewed-by: Iker Pedrosa <[email protected]> Reviewed-by: Justin Stephenson <[email protected]> (cherry picked from commit df8472c)
Following three minor changes are: for test_config_validation.py, 1. 'sssctl config-check' returning retuncode as a 1 when we dont have sssd.conf file. 2. Change the 'sssctl' command which only check the non-default snippet directory with option -s. for test_offline.py, 3. Add extra restart of sssd to get offline log message using journalctl command. for test_ssh_ 4. Replace pexpect_ssh to auth_from_client method to login the user. Signed-off-by: Madhuri Upadhye <[email protected]> Reviewed-by: Jakub Vávra <[email protected]> Reviewed-by: Shridhar Gadekar <[email protected]> (cherry picked from commit 2965db1)
moved default debug level tests to tier2 Reviewed-by: Jakub Vávra <[email protected]> (cherry picked from commit 535a8c6)
It fixes test from tire1_2 that is failling in gating 1. src/tests/multihost/alltests/test_automount.py there is issue with autofs email thead: [CRASH] prep Package: autofs-1:5.1.7-36.el9 2. src/tests/multihost/alltests/test_automount_from_bash.py test did not rised error as last cd - command was successful, so i have remove cd - part(/folder1/folder2/projects does not exists) 3. src/tests/multihost/alltests/test_ldap_password_policy.py password provied was wrong. 4. src/tests/multihost/alltests/test_backtrace.py --- need to modify this test as per current log format Reviewed-by: Jakub Vávra <[email protected]> Reviewed-by: Shridhar Gadekar <[email protected]> (cherry picked from commit 2096f45)
* fixing raiseonerr=False to disjoin function * cleaned up code since the line limit has increased * added AD from forest1 to resolv.conf and /etc/hosts * updating test case documentation to clarify the test Signed-off-by: Dan Lavu <[email protected]> Reviewed-by: Jakub Vávra <[email protected]> Reviewed-by: Madhuri Upadhye <[email protected]> Reviewed-by: Scott Poore <[email protected]> (cherry picked from commit 69f93bf)
IPA passkey configuration may not be retrieved if IPA does not contain passkey support. Lower the error level of log messages associated with this failure. Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Iker Pedrosa <[email protected]> (cherry picked from commit fe751c3)
Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Iker Pedrosa <[email protected]> (cherry picked from commit fa326be)
Reviewed-by: Iker Pedrosa <[email protected]> Reviewed-by: Justin Stephenson <[email protected]> (cherry picked from commit 39b6337)
Reviewed-by: Anuj Borah <[email protected]>
If krb5_child runs into a timeout the backend currently does not close the I/O sockets because handle_child_done() is not called when the timeout handlers are acting. To make sure the signal handler can close the sockets the 'in_use' member of struct child_io_fds is set to 'false'. Resolves: SSSD#6744 Reviewed-by: Alejandro López <[email protected]> Reviewed-by: Alexey Tikhonov <[email protected]> (cherry picked from commit 4556119)
modified docstrings Reviewed-by: Jakub Vávra <[email protected]> Reviewed-by: Madhuri Upadhye <[email protected]> (cherry picked from commit 11eef22)
Make enum sysdb_obj_type usable outside of sysdb_ops.c. Reviewed-by: Sumit Bose <[email protected]> Reviewed-by: Tomáš Halman <[email protected]> (cherry picked from commit 1d69fdb)
The previous filter for overrides would sometimes find more than one entry because it was looking for a uidNumber or gidNumber: (&(objectClass=ipaOverrideAnchor)(|(uidNumber=XXXX)(gidNumber=XXXX))) The new filter looks for a specific user override or a specific group override: (|(&(objectClass=ipaUserOverride)(uidNumber=XXXX)) (&(objectClass=ipaGroupOverride)(gidNumber=XXXX))) This filter could return two override entries (one for a group and one for a user). That case must be taken into consideration and discard the user override in favor of the group override. Reviewed-by: Sumit Bose <[email protected]> Reviewed-by: Tomáš Halman <[email protected]> (cherry picked from commit 99d0ab8)
Reviewed-by: Madhuri Upadhye <[email protected]> (cherry picked from commit 469905b)
Calls to add_expired_warning(struct pam_data *pd, long exp_time) must provide a non-NULL pd. In one of the cases this function is called without checking that pd is not NULL. We here fix that. Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Sumit Bose <[email protected]> (cherry picked from commit 7f28816)
A missing server name in struct fo_server will cause a segmentation fault. Currently it is unclear why the server name is missing at this point. To avoid the segmentation fault it is checked before if the server name is missing. Additionally the state of some internal structures is added to the debug logs to help debugging why the server name is missing. Resolves: SSSD#6659 Reviewed-by: Alejandro López <[email protected]> Reviewed-by: Alexey Tikhonov <[email protected]> (cherry picked from commit 8a88699)
https://gitlab.cee.redhat.com/sssd/sssd-qe/-/blob/RHEL8.8/client/ldap_provider/ldap_id_ldap_auth/bugzilla-automation.sh#L280 Reviewed-by: Jakub Vávra <[email protected]> Reviewed-by: Shridhar Gadekar <[email protected]> (cherry picked from commit 75ae9e8)
Tests moved to tier2, tests are failing to parse the logs. gating is blocked. same testsuite is available in bash Reviewed-by: Dan Lavu <[email protected]> (cherry picked from commit 587cd8d)
removing flaky ones Reviewed-by: Jakub Vávra <[email protected]> (cherry picked from commit 27dd3f5)
Resolves: SSSD#6442 Reviewed-by: Sumit Bose <[email protected]> Reviewed-by: Tomáš Halman <[email protected]> (cherry picked from commit 076a113)
When a netgroup is updated, previously it did not remove the missing attributes. This caused an issue especially when a member was removed. Resolves: SSSD#6652 Reviewed-by: Alejandro López <[email protected]> Reviewed-by: Iker Pedrosa <[email protected]> (cherry picked from commit b033b0d)
The conditions to use the shortcut in sdap_ad_tokengroups_initgroups_send() were modified without also changing sdap_ad_tokengroups_initgroups_done(). To avoid future problems like this, and because the condition is becoming more complex to evaluate, we evaluate the condition in the _send() function and keep the result in the state, for the _done() function to use it. Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Sumit Bose <[email protected]> (cherry picked from commit dc9466e)
Adding package iproute-tc to get tc command. Signed-off-by: Madhuri Upadhye <[email protected]> Reviewed-by: Jakub Vávra <[email protected]> Reviewed-by: Shridhar Gadekar <[email protected]> (cherry picked from commit 9c50b8e)
Dropping unstable dyndns tests from c-ares gating (cherry picked from commit 6efb277)
The test is unstable on other architectures so it is skipped for now. Reviewed-by: Madhuri Upadhye <[email protected]> (cherry picked from commit d14be79)
…ectures. The test is unstable on other architectures so it is skipped for now. Reordered the asserts so we can seed if the connection to AD works as looking for log message has a lower priority. Reviewed-by: Madhuri Upadhye <[email protected]> (cherry picked from commit 3e3d098)
Similar to string_in_list() but instead of taking a NULL-terminated list it take a list and its size. Reviewed-by: Iker Pedrosa <[email protected]> Reviewed-by: Sumit Bose <[email protected]> (cherry picked from commit 1b45f29)
Old function add_strings_lists() copies any duplicate value. New function add_strings_lists_ex() take an argument to decide whether to discard duplicate values. add_strings_lists() is now a wrapper on add_strings_lists_ex(). Both function now take a const char *** instead of char ** as output parameter. An existing test was adapted and an new one added. Reviewed-by: Iker Pedrosa <[email protected]> Reviewed-by: Sumit Bose <[email protected]> (cherry picked from commit 2b8fed5)
Both functions do the same thing, so it is useless to have them both. attr_in_list() has, however, a more descriptive name for its use in this module, so we'll keep it as an inlined wrapper. Reviewed-by: Iker Pedrosa <[email protected]> Reviewed-by: Sumit Bose <[email protected]> (cherry picked from commit de258f0)
The extra attributes are concatenated to other required attributes for some operations. In some cases the attribute list ends up having duplicate attributes, either because accidentally the user added it twice to the ldap_user_extra_attrs list, or one or more of those attributes are also in the required list. Removing the duplicates each time the lists are concatenated increases the concatenation time. And this is done every time. So we try to concatenate the attribute lists at start up, filtering duplicates, and use that list. To do that, we consider the two cases where the list concatenation is done. In one of the cases, the added attributes are a subset of the other list. So we factorized this list to add the common attributes to the list at start up. Only the non-common attributes are added while serving a request. The complete list is now stored in the `full_attribute_list` field. An existing test suite was adapted to this new situation as it now needs to initialize the new field. Reviewed-by: Iker Pedrosa <[email protected]> Reviewed-by: Sumit Bose <[email protected]> (cherry picked from commit b504159)
(Korean) currently translated at 100.0% (714 of 714 strings) Translation: SSSD/SSSD-2-9 Translate-URL: https://translate.fedoraproject.org/projects/sssd/sssd-2-9/ko/
(Ukrainian) currently translated at 100.0% (714 of 714 strings) Translation: SSSD/SSSD-2-9 Translate-URL: https://translate.fedoraproject.org/projects/sssd/sssd-2-9/uk/
(Georgian) currently translated at 8.1% (58 of 714 strings) Translation: SSSD/SSSD-2-9 Translate-URL: https://translate.fedoraproject.org/projects/sssd/sssd-2-9/ka/
(Korean) currently translated at 100.0% (714 of 714 strings) Translation: SSSD/SSSD-2-9 Translate-URL: https://translate.fedoraproject.org/projects/sssd/sssd-2-9/ko/
(Turkish) currently translated at 98.7% (705 of 714 strings) Translation: SSSD/SSSD-2-9 Translate-URL: https://translate.fedoraproject.org/projects/sssd/sssd-2-9/tr/
(Polish) currently translated at 100.0% (714 of 714 strings) Translation: SSSD/SSSD-2-9 Translate-URL: https://translate.fedoraproject.org/projects/sssd/sssd-2-9/pl/
(Russian) currently translated at 100.0% (714 of 714 strings) Translation: SSSD/SSSD-2-9 Translate-URL: https://translate.fedoraproject.org/projects/sssd/sssd-2-9/ru/
(French) currently translated at 100.0% (714 of 714 strings) Translation: SSSD/SSSD-2-9 Translate-URL: https://translate.fedoraproject.org/projects/sssd/sssd-2-9/fr/
(Japanese) currently translated at 100.0% (714 of 714 strings) Translation: SSSD/SSSD-2-9 Translate-URL: https://translate.fedoraproject.org/projects/sssd/sssd-2-9/ja/
(Chinese (Simplified) (zh_CN)) currently translated at 100.0% (714 of 714 strings) Translation: SSSD/SSSD-2-9 Translate-URL: https://translate.fedoraproject.org/projects/sssd/sssd-2-9/zh_CN/
…verride
Add automation of BZ2096183.
verifies:
SSSD#6671
Signed-off-by: Madhuri Upadhye <[email protected]>
Reviewed-by: Alejandro López <[email protected]>
Reviewed-by: Jakub Vávra <[email protected]>
(cherry picked from commit 377ec31)
…n sssd.conf the cross-forest query stop working When adding attributes ldap_user_extra_attrs with mail value in sssd.conf the cross-forest query stop working Automation of BZ2170720 Verifies: SSSD#6759 Signed-off-by: Madhuri Upadhye <[email protected]> Reviewed-by: Alejandro López <[email protected]> Reviewed-by: Jakub Vávra <[email protected]> (cherry picked from commit 57499ff)
Using new authentication module for ssh login instead of existing one Reviewed-by: Anuj Borah <[email protected]> (cherry picked from commit 0171bcb)
Fix alltest tier1_3 tests with new ssh module Reviewed-by: Shridhar Gadekar <[email protected]> (cherry picked from commit 5674120)
Fix IPA tire1_2 tests Reviewed-by: Jakub Vávra <[email protected]> (cherry picked from commit 7f94e5c)
Reviewed-by: Alejandro López <[email protected]> Reviewed-by: Sumit Bose <[email protected]> (cherry picked from commit 74d0f45) Reviewed-by: Sumit Bose <[email protected]>
Those two new calls can be used if there are requests stuck by e.g. waiting on replies where there is no other way to handle the timeout and get the system back into a stable state. They should be only used as a last resort. Resolves: SSSD#6803 Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Pavel Březina <[email protected]> (cherry picked from commit 75f2b35)
There seem to be conditions where the reply in the sbus_call_DBus_Hello_send() request gets lost and the backend cannot properly initialize its sbus/DBus server. Since the backend cannot be connected by the frontends in this state the best way to recover would be a restart. Since the event-loop is active in this state, e.g. waiting for the reply, the watchdog will not consider the process as hung and will not restart the process. To make the watchdog handle this case arm_watchdog() and disarm_watchdog() are called before and after the request, respectively. Resolves: SSSD#6803 Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Pavel Březina <[email protected]> (cherry picked from commit cca9361)
…w sssd change Update test_ldap_password_policy.py::test_maxage as per the new sssd change Reviewed-by: Shridhar Gadekar <[email protected]> (cherry picked from commit 5e86af8)
Fix test_0002_bz1928648 with new ssh module Reviewed-by: Shridhar Gadekar <[email protected]> (cherry picked from commit 2487c99)
Update tier1 test cases with new ssh module Reviewed-by: Shridhar Gadekar <[email protected]> (cherry picked from commit 6690822)
Remove multihost basic tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove multihost basic tests