-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only create sysdb cache files from 'monitor' (and tests) #7558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-tikhonov
added
no-backport
This should go to target branch only.
non-privileged
labels
Sep 3, 2024
alexey-tikhonov
force-pushed
the
tools-root-check2
branch
from
September 4, 2024 11:50
305faa8
to
bb54213
Compare
alexey-tikhonov
changed the title
Don't create sysdb cache from tools
Only create sysdb cache files from 'monitor'
Sep 4, 2024
alexey-tikhonov
force-pushed
the
tools-root-check2
branch
from
September 4, 2024 14:33
bb54213
to
63592e0
Compare
alexey-tikhonov
changed the title
Only create sysdb cache files from 'monitor'
Only create sysdb cache files from 'monitor' (and tests)
Sep 4, 2024
alexey-tikhonov
force-pushed
the
tools-root-check2
branch
from
September 5, 2024 09:24
63592e0
to
eea2776
Compare
andreboscatto
requested review from
thalman and
pbrezina
and removed request for
sumit-bose
September 5, 2024 12:45
alexey-tikhonov
force-pushed
the
tools-root-check2
branch
from
September 5, 2024 18:49
eea2776
to
5b8591b
Compare
(rebased) |
pbrezina
approved these changes
Sep 12, 2024
It's reasonable to expect that nobody will attempt an upgrade from DB version older than "0.16" (sssd-1.12) to "0.25"+
Everything else (providers, responders, tools) should only connect to.
alexey-tikhonov
force-pushed
the
tools-root-check2
branch
from
September 13, 2024 17:08
5b8591b
to
c40f7c4
Compare
alexey-tikhonov
force-pushed
the
tools-root-check2
branch
from
September 14, 2024 16:45
24b074e
to
083130e
Compare
pbrezina
approved these changes
Sep 16, 2024
thalman
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid wrong files ownership if user used to run tools and SSSD differs.