Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect '--without-infopipe' in 'sssctl' and tests #7543

Closed

Conversation

alexey-tikhonov
Copy link
Member

No description provided.

@alexey-tikhonov alexey-tikhonov added the no-backport This should go to target branch only. label Aug 21, 2024
@alexey-tikhonov alexey-tikhonov marked this pull request as ready for review August 21, 2024 14:55
@pbrezina
Copy link
Member

Thank you. I wonder if it wouldn't be better to remove the build condition? Infopipe is there for years and built by default, I think the build condition was introduced for times when ifp was experimental.

@alexey-tikhonov
Copy link
Member Author

if it wouldn't be better to remove the build condition?

Minimalistic container service doesn't need 'sssd_ifp' (and probably doesn't run dbus-broker).

@pbrezina
Copy link
Member

if it wouldn't be better to remove the build condition?

Minimalistic container service doesn't need 'sssd_ifp' (and probably doesn't run dbus-broker).

In this scenario however, sssd will still be installed via packaging system and not built directly on the container. So ifp will be built, only sssd-dbus package won't be installed. Or do I miss something?

@alexey-tikhonov
Copy link
Member Author

if it wouldn't be better to remove the build condition?

Minimalistic container service doesn't need 'sssd_ifp' (and probably doesn't run dbus-broker).

In this scenario however, sssd will still be installed via packaging system and not built directly on the container. So ifp will be built, only sssd-dbus package won't be installed. Or do I miss something?

I'm using this build option in #7262 to experiment with resulting copr build.

One of the things I'm trying to do there is to minimize install dependencies to be able to install SSSD on a really minimal container image.
So in that PR I switched off everything not really needed.

Probably '--without-infopipe' indeed isn't important (libdbus dependency is there due to SBUS anyway, so maybe there are no extra deps), but I thought having this option fixed won't hurt...

@pbrezina
Copy link
Member

pbrezina commented Aug 23, 2024

if it wouldn't be better to remove the build condition?

Minimalistic container service doesn't need 'sssd_ifp' (and probably doesn't run dbus-broker).

In this scenario however, sssd will still be installed via packaging system and not built directly on the container. So ifp will be built, only sssd-dbus package won't be installed. Or do I miss something?

I'm using this build option in #7262 to experiment with resulting copr build.

One of the things I'm trying to do there is to minimize install dependencies to be able to install SSSD on a really minimal container image. So in that PR I switched off everything not really needed.

Probably '--without-infopipe' indeed isn't important (libdbus dependency is there due to SBUS anyway, so maybe there are no extra deps), but I thought having this option fixed won't hurt...

It shouldn't bring any extra deps. Won't hurt, I'd personally like to see it removed instead of complicate things since I don't think there is any value in the conditional build now. But I can go either way, the patch is fine, obviously. However we would need to also add proper skip to system tests.

@alexey-tikhonov
Copy link
Member Author

Ok, I'll remove build option instead.

@alexey-tikhonov
Copy link
Member Author

Ok, I'll remove build option instead.

#7545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport This should go to target branch only. Rejected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants