-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect '--without-infopipe' in 'sssctl' and tests #7543
Conversation
Thank you. I wonder if it wouldn't be better to remove the build condition? Infopipe is there for years and built by default, I think the build condition was introduced for times when ifp was experimental. |
Minimalistic container service doesn't need 'sssd_ifp' (and probably doesn't run dbus-broker). |
In this scenario however, sssd will still be installed via packaging system and not built directly on the container. So ifp will be built, only sssd-dbus package won't be installed. Or do I miss something? |
I'm using this build option in #7262 to experiment with resulting copr build. One of the things I'm trying to do there is to minimize install dependencies to be able to install SSSD on a really minimal container image. Probably '--without-infopipe' indeed isn't important ( |
It shouldn't bring any extra deps. Won't hurt, I'd personally like to see it removed instead of complicate things since I don't think there is any value in the conditional build now. But I can go either way, the patch is fine, obviously. However we would need to also add proper skip to system tests. |
Ok, I'll remove build option instead. |
|
No description provided.