Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: updating gpo test case to test all auto_private_group values #7524

Closed
wants to merge 1 commit into from

Conversation

danlavu
Copy link

@danlavu danlavu commented Aug 5, 2024

No description provided.

Copy link
Contributor

@spoore1 spoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you have test runs with this change?

@danlavu
Copy link
Author

danlavu commented Aug 6, 2024

LGTM. Do you have test runs with this change?

The test is failing, provided logs to @thalman already.

@danlavu
Copy link
Author

danlavu commented Aug 7, 2024

The test is passing in idmci on rhel10, provided the internal link, directly to individuals.

Copy link
Contributor

@spoore1 spoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@thalman thalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@thalman thalman added Accepted and removed Accepted labels Aug 14, 2024
@thalman
Copy link
Contributor

thalman commented Aug 14, 2024

I removed the "accepted" flag just because the PR is in "Draft". @danlavu - is that correct? I it still draft?

@danlavu danlavu marked this pull request as ready for review August 14, 2024 12:48
@danlavu
Copy link
Author

danlavu commented Aug 14, 2024

I moved it out of draft, one of the test wasn't working locally but it did work in idmci.

@alexey-tikhonov
Copy link
Member

Pushed PR: #7524

  • master
    • 34cd828 - tests: updating gpo test case to test all auto_private_group values
  • sssd-2-9
    • 61408c8 - tests: updating gpo test case to test all auto_private_group values

@danlavu danlavu deleted the tests-gpo-apg branch November 4, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants