-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: housekeeping, test_ldap.py #7506
Conversation
28ab2f3
to
428e0b2
Compare
428e0b2
to
d206c65
Compare
@danlavu, doesn't this de-sync 'master' and 'sssd-2-9' branches? |
Yes, the ppolicy feature is not available in 2-9. Now, master contains
that we can skip the tests and leave the un-used test code. Do we want to remove it from 2-9 or add the marker to skip the tests in this branch? |
housekeeping, the following is looked at and may have been done: * fixed typos and standardized formatting * renamed test cases to improve the clarity of what the test does * improved docstring language, setup, steps and expected results * synced code with the docstring order * removed necessary configuration relevant to the test * added pytest.mark.importance to test cases noteable changes: * removed lookup_user_default_naming_context_and_no_search_base because it is already covered by another test scenario added description to ppolicy tests, providing an explanation * removed enumeration configuration from tests where enumeration is not being tested * removed test case checking log messages for timeout Reviewed-by: Alejandro López <[email protected]> Reviewed-by: Anuj Borah <[email protected]> Reviewed-by: Shridhar Gadekar <[email protected]> (cherry picked from commit 8c19d7b)
d206c65
to
6d807ec
Compare
I spoke to Jakub. It will be harder to maintain if we drop these tests, so I've added them back in. You can see the tests are skipped for this branch.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
housekeeping, the following is looked at and may have been done:
noteable changes:
Reviewed-by: Alejandro López [email protected]
Reviewed-by: Anuj Borah [email protected]
Reviewed-by: Shridhar Gadekar [email protected]
(cherry picked from commit 8c19d7b)