Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPEC: merge 'sssd-polkit-rules' into 'sssd-common' #7504

Closed
wants to merge 1 commit into from
Closed

SPEC: merge 'sssd-polkit-rules' into 'sssd-common' #7504

wants to merge 1 commit into from

Conversation

alexey-tikhonov
Copy link
Member

'p11_child' runs under non-privileged user and thus requires polkit-rules by default.

@alexey-tikhonov
SPEC: merge 'sssd-polkit-rules' into 'sssd-common'
0ac0b6f 
'p11_child' runs under non-privileged user and thus requires
polkit-rules by default.
@alexey-tikhonov alexey-tikhonov added no-backport This should go to target branch only. Waiting for review labels Jul 23, 2024
@alexey-tikhonov
Copy link
Member Author

Open question: should we add 'Requires: polkit' to 'sssd-common'?

sumit-bose
sumit-bose approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@sumit-bose sumit-bose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
thank you, I'm fine with the changes, ACK.
bye,
Sumit

@alexey-tikhonov
Copy link
Member Author

https://issues.redhat.com/browse/RHEL-50243

@andreboscatto andreboscatto requested a review from spoore1 July 25, 2024 13:22
@thalman
Copy link
Contributor

thalman commented Jul 25, 2024

LGTM

@justin-stephenson justin-stephenson mentioned this pull request Jul 25, 2024
Closed
spoore1
spoore1 reviewed Jul 25, 2024
View reviewed changes
Copy link
Contributor

@spoore1 spoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks ok but, I've been unable to successfully test today with smart cards due to other issues I'm having.

spoore1
spoore1 approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@spoore1 spoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the issues I saw are even remotely related to this. And considering that it's been tested elsewhere, I think this can be merged.

@alexey-tikhonov
Copy link
Member Author

Pushed PR: #7504

  • master
    • a7d0bbe - SPEC: merge 'sssd-polkit-rules' into 'sssd-common'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumit-bose sumit-bose sumit-bose approved these changes

@spoore1 spoore1 spoore1 approved these changes

Assignees

@thalman thalman

@spoore1 spoore1

@sumit-bose sumit-bose

Labels
Bugzilla no-backport This should go to target branch only. Pushed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexey-tikhonov @thalman @spoore1 @sumit-bose