tests: housekeeping - sss_override #7487
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-tikhonov
requested review from
aplopez
and removed request for
alexey-tikhonov
aplopez
reviewed
Jul 15, 2024
danlavu
force-pushed
the
tests-housekeeping-sss_override
branch
3 times, most recently
from
377b019 to
2265713
Compare
aplopez
reviewed
Jul 16, 2024
danlavu
force-pushed
the
tests-housekeeping-sss_override
branch
2 times, most recently
from
14a5607 to
79f0de5
Compare
shridhargadekar
approved these changes
Jul 24, 2024
danlavu
force-pushed
the
tests-housekeeping-sss_override
branch
2 times, most recently
from
d43c5b3 to
c07d954
Compare
|
@danlavu, were recent updates merely rebases? |
|
This PR was fixing a variable, lines 229 and 230. |
|
@danlavu, please rebase |
|
@shridhargadekar, @aplopez, please re-review after rebase |
danlavu
force-pushed
the
tests-housekeeping-sss_override
branch
2 times, most recently
from
e1c3824 to
3d97d55
Compare
danlavu
force-pushed
the
tests-housekeeping-sss_override
branch
from
3d97d55 to
4110fd2
Compare
|
@shridhargadekar poke |
danlavu
force-pushed
the
tests-housekeeping-sss_override
branch
from
4110fd2 to
8151723
Compare
shridhargadekar
requested changes
Aug 21, 2024
danlavu
force-pushed
the
tests-housekeeping-sss_override
branch
2 times, most recently
from
d43fead to
45f342a
Compare
housekeeping, the following is looked at and may have been done: * fixed typos and standardized formatting * renamed test cases to improve the clarity of what the test does * improved docstring language, setup, steps and expected results * synced code with the docstring order * removed necessary configuration relevant to the test * added pytest.mark.importance to test cases noteable changes:
danlavu
force-pushed
the
tests-housekeeping-sss_override
branch
from
45f342a to
144cf5d
Compare
shridhargadekar
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
housekeeping, the following is looked at and may have been done:
noteable changes: