Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: housekeeping, test_failover.py #7467

Closed
wants to merge 1 commit into from
Closed

tests: housekeeping, test_failover.py #7467

wants to merge 1 commit into from

Conversation

danlavu
Copy link

@danlavu danlavu commented Jun 29, 2024 •
edited
Loading

  • extended the test to the generic provider
  • added assertion error messages
  • improved some grammar and word choice

@danlavu danlavu requested a review from pbrezina July 1, 2024 13:57
@danlavu danlavu marked this pull request as draft July 1, 2024 14:13
@danlavu danlavu removed the Trivial label Jul 1, 2024
@danlavu danlavu force-pushed the tests-housekeeping-tests_failover_py branch 2 times, most recently from edccffc to bc5ea90 Compare July 1, 2024 18:16
@danlavu danlavu marked this pull request as ready for review July 1, 2024 18:16
@danlavu danlavu requested a review from shridhargadekar July 1, 2024 18:17
@danlavu
Copy link
Author

danlavu commented Jul 1, 2024

Removing backports after realizing this is a new feature. I still need to run it against a version of SSSD that contains the feature, it's fine for review, I just need to test it before it's merged.

@danlavu
Copy link
Author

danlavu commented Jul 9, 2024 

2024-07-08T23:32:04 =========================== short test summary info ============================
2024-07-08T23:32:04 PASSED ../sssd/src/tests/system/tests/test_failover.py::test_failover__reactivation_timeout_is_honored[None-31] (ad)
2024-07-08T23:32:04 PASSED ../sssd/src/tests/system/tests/test_failover.py::test_failover__reactivation_timeout_is_honored[15-31] (ad)
2024-07-08T23:32:04 PASSED ../sssd/src/tests/system/tests/test_failover.py::test_failover__reactivation_timeout_is_honored[60-60] (ad)
2024-07-08T23:32:04 PASSED ../sssd/src/tests/system/tests/test_failover.py::test_failover__reactivation_timeout_is_honored[None-31] (ipa)
2024-07-08T23:32:04 PASSED ../sssd/src/tests/system/tests/test_failover.py::test_failover__reactivation_timeout_is_honored[15-31] (ipa)
2024-07-08T23:32:04 PASSED ../sssd/src/tests/system/tests/test_failover.py::test_failover__reactivation_timeout_is_honored[60-60] (ipa)
2024-07-08T23:32:04 PASSED ../sssd/src/tests/system/tests/test_failover.py::test_failover__reactivation_timeout_is_honored[None-31] (ldap)
2024-07-08T23:32:04 PASSED ../sssd/src/tests/system/tests/test_failover.py::test_failover__reactivation_timeout_is_honored[15-31] (ldap)
2024-07-08T23:32:04 PASSED ../sssd/src/tests/system/tests/test_failover.py::test_failover__reactivation_timeout_is_honored[60-60] (ldap)
2024-07-08T23:32:04 PASSED ../sssd/src/tests/system/tests/test_failover.py::test_failover__reactivation_timeout_is_honored[None-31] (samba)
2024-07-08T23:32:04 PASSED ../sssd/src/tests/system/tests/test_failover.py::test_failover__reactivation_timeout_is_honored[15-31] (samba)
2024-07-08T23:32:04 PASSED ../sssd/src/tests/system/tests/test_failover.py::test_failover__reactivation_timeout_is_honored[60-60] (samba)
2024-07-08T23:32:04 ================ 12 passed, 551 deselected in 350.20s (0:05:50) ================

Test code is passing

@pbrezina
Copy link
Member

Run isort on it, otherwise ack.

@danlavu danlavu force-pushed the tests-housekeeping-tests_failover_py branch from bc5ea90 to 086e69d Compare July 12, 2024 18:23
@pbrezina
Copy link
Member

@shridhargadekar Why did you ack, when the test fails in PR CI?

@danlavu Please, investigate the test failures. The code is provider-independent so there must be a problem with the test or CI environment.

@danlavu
Copy link
Author

danlavu commented Jul 16, 2024

@shridhargadekar Why did you ack, when the test fails in PR CI?

@danlavu Please, investigate the test failures. The code is provider-independent so there must be a problem with the test or CI environment.

So I've run the tests against hosts in downstream ci and locally, and they are passing. I'm going to take a look at the logs and will probably have questions about the differences between them.

@danlavu danlavu force-pushed the tests-housekeeping-tests_failover_py branch from 086e69d to 1384d59 Compare July 17, 2024 01:15
@danlavu
Copy link
Author

danlavu commented Jul 17, 2024 •
edited
Loading

@pbrezina

I amended the change, giving samba it's own section. The discovered realm was resolving to AD.TEST and not SAMBA.TEST it seems. Not all tests have been executed, but they are passing now.

@alexey-tikhonov
Copy link
Member

@pbrezina, are you fine with the latest version?

@danlavu danlavu force-pushed the tests-housekeeping-tests_failover_py branch from 1384d59 to d52f6c1 Compare July 24, 2024 13:12
@danlavu danlavu removed the request for review from pbrezina July 24, 2024 13:13
@danlavu danlavu requested a review from pbrezina July 24, 2024 16:31
@danlavu danlavu requested a review from shridhargadekar July 24, 2024 16:32
tests: housekeeping - test_failover.py
8e89e66 
* extended the test to the generic provider
* added assertion error messages
* improved some grammar and word choice
@danlavu danlavu force-pushed the tests-housekeeping-tests_failover_py branch from d52f6c1 to 8e89e66 Compare July 24, 2024 18:36
@alexey-tikhonov
Copy link
Member

Pushed PR: #7467

  • master
    • 4d1c4d7 - tests: housekeeping - test_failover.py
  • sssd-2-9
    • b98dab5 - tests: housekeeping - test_failover.py

@danlavu danlavu deleted the tests-housekeeping-tests_failover_py branch November 4, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbrezina pbrezina pbrezina approved these changes

@shridhargadekar shridhargadekar shridhargadekar approved these changes

Assignees

@shridhargadekar shridhargadekar

@pbrezina pbrezina

Labels
Pushed Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danlavu @pbrezina @alexey-tikhonov @shridhargadekar @jakub-vavra-cz