tests: housekeeping, test_identity.py #7461

danlavu · 2024-06-26T04:44:40Z

housekeeping, the following is looked at and may have been done:

fixed typos and standardized formatting
renamed test cases to improve the clarity of what the test does
improved docstring language, setup, steps and expected results
synced code with the docstring order
removed necessary configuration relevant to the test
added pytest.mark.importance to test cases

noteable changes:

auto_private_group tests reworked, adding two more test cases

danlavu · 2024-06-26T05:11:37Z

Looking at the docs for auto_private_groups. and adding assertions to what I understand to better test this feature. This is failing for the IPA topology; is this expected? Is there something different about IPA?

============================= test session starts ==============================
collecting ... 

Selected tests will use the following hosts:
  client: client.test
  ad: dc.ad.test
  samba: dc.samba.test
  kdc: kdc.test
  ipa: master.ipa.test
  ldap: master.ldap.test
  nfs: nfs.test

collected 552 items / 486 deselected / 66 selected

tests/test_identity.py::test_identity__lookup_username_with_id_command[root] (ad) 
tests/test_identity.py::test_identity__lookup_username_with_id_command[sssd] (ad) 
tests/test_identity.py::test_identity__lookup_uid_with_id_command[root] (ad) 
tests/test_identity.py::test_identity__lookup_uid_with_id_command[sssd] (ad) 
tests/test_identity.py::test_identity__lookup_groupname_with_getent (ad) 
tests/test_identity.py::test_identity__lookup_group_gid_with_getent (ad) 
tests/test_identity.py::test_identity__lookup_user_with_getent (ad) 
tests/test_identity.py::test_identity__lookup_groups_by_name_and_gid_with_getent (ad) 
tests/test_identity.py::test_identity__lookup_group_membership_by_username_with_id_command[root] (ad) 
tests/test_identity.py::test_identity__lookup_group_membership_by_username_with_id_command[sssd] (ad) 
tests/test_identity.py::test_identity__lookup_group_membership_by_group_with_id_command (ad) 
tests/test_identity.py::test_identity__lookup_initgroups_with_getent (ad) 
tests/test_identity.py::test_identity__lookup_users_with_fully_qualified_name (ad) 
tests/test_identity.py::test_identity__lookup_users_when_case_insensitive_is_false (ad) 
tests/test_identity.py::test_identity__lookup_users_fully_qualified_name_and_case_insensitive_is_false (ad) 
tests/test_identity.py::test_identity__lookup_id_mapping_of_posix_and_non_posix_user_and_group (ad) 
tests/test_identity.py::test_identity__lookup_when_auto_private_groups_is_set_to_hybrid (ad) 
tests/test_identity.py::test_identity__lookup_username_with_id_command[root] (ipa) 
tests/test_identity.py::test_identity__lookup_username_with_id_command[sssd] (ipa) 
tests/test_identity.py::test_identity__lookup_uid_with_id_command[root] (ipa) 
tests/test_identity.py::test_identity__lookup_uid_with_id_command[sssd] (ipa) 
tests/test_identity.py::test_identity__lookup_groupname_with_getent (ipa) 
tests/test_identity.py::test_identity__lookup_group_gid_with_getent (ipa) 
tests/test_identity.py::test_identity__lookup_user_with_getent (ipa) 
tests/test_identity.py::test_identity__lookup_groups_by_name_and_gid_with_getent (ipa) 
tests/test_identity.py::test_identity__lookup_group_membership_by_username_with_id_command[root] (ipa) 
tests/test_identity.py::test_identity__lookup_initgroups_with_getent (ipa) 
tests/test_identity.py::test_identity__lookup_users_with_fully_qualified_name (ipa) 
tests/test_identity.py::test_identity__lookup_users_when_case_insensitive_is_false (ipa) 
tests/test_identity.py::test_identity__lookup_users_fully_qualified_name_and_case_insensitive_is_false (ipa) 
tests/test_identity.py::test_identity__lookup_when_auto_private_groups_is_set_to_hybrid (ipa) 
tests/test_identity.py::test_identity__lookup_username_with_id_command[root] (ldap) 
tests/test_identity.py::test_identity__lookup_username_with_id_command[sssd] (ldap) 
tests/test_identity.py::test_identity__lookup_uid_with_id_command[root] (ldap) 
tests/test_identity.py::test_identity__lookup_uid_with_id_command[sssd] (ldap) 
tests/test_identity.py::test_identity__lookup_groupname_with_getent (ldap) 
tests/test_identity.py::test_identity__lookup_group_gid_with_getent (ldap) 
tests/test_identity.py::test_identity__lookup_user_with_getent (ldap) 
tests/test_identity.py::test_identity__lookup_groups_by_name_and_gid_with_getent (ldap) 
tests/test_identity.py::test_identity__lookup_group_membership_by_username_with_id_command[root] (ldap) 
tests/test_identity.py::test_identity__lookup_group_membership_by_username_with_id_command[sssd] (ldap) 
tests/test_identity.py::test_identity__lookup_group_membership_by_group_with_id_command (ldap) 
tests/test_identity.py::test_identity__lookup_initgroups_with_getent (ldap) 
tests/test_identity.py::test_identity__lookup_users_with_fully_qualified_name (ldap) 
tests/test_identity.py::test_identity__lookup_users_when_case_insensitive_is_false (ldap) 
tests/test_identity.py::test_identity__lookup_users_fully_qualified_name_and_case_insensitive_is_false (ldap) 
tests/test_identity.py::test_identity__lookup_when_auto_private_groups_is_set_to_hybrid (ldap) 
tests/test_identity.py::test_identity__lookup_username_with_id_command[root] (samba) 
tests/test_identity.py::test_identity__lookup_username_with_id_command[sssd] (samba) 
tests/test_identity.py::test_identity__lookup_uid_with_id_command[root] (samba) 
tests/test_identity.py::test_identity__lookup_uid_with_id_command[sssd] (samba) 
tests/test_identity.py::test_identity__lookup_groupname_with_getent (samba) 
tests/test_identity.py::test_identity__lookup_group_gid_with_getent (samba) 
tests/test_identity.py::test_identity__lookup_user_with_getent (samba) 
tests/test_identity.py::test_identity__lookup_groups_by_name_and_gid_with_getent (samba) 
tests/test_identity.py::test_identity__lookup_group_membership_by_username_with_id_command[root] (samba) 
tests/test_identity.py::test_identity__lookup_group_membership_by_username_with_id_command[sssd] (samba) 
tests/test_identity.py::test_identity__lookup_group_membership_by_group_with_id_command (samba) 
tests/test_identity.py::test_identity__lookup_initgroups_with_getent (samba) 
tests/test_identity.py::test_identity__lookup_users_with_fully_qualified_name (samba) 
tests/test_identity.py::test_identity__lookup_users_when_case_insensitive_is_false (samba) 
tests/test_identity.py::test_identity__lookup_users_fully_qualified_name_and_case_insensitive_is_false (samba) 
tests/test_identity.py::test_identity__lookup_id_mapping_of_posix_and_non_posix_user_and_group (samba) 
tests/test_identity.py::test_identity__lookup_when_auto_private_groups_is_set_to_hybrid (samba) 

===== 1 failed, 53 passed, 12 skipped, 486 deselected in 490.71s (0:08:10) =====
PASSED [  1%]SKIPPED [  3%]
Skipped: SSSD was built without support for running under non-root
PASSED [  4%]SKIPPED [  6%]
Skipped: SSSD was built without support for running under non-root
PASSED [  7%]PASSED [  9%]PASSED [ 10%]PASSED [ 12%]PASSED [ 13%]SKIPPED [ 15%]
Skipped: SSSD was built without support for running under non-root
PASSED [ 16%]PASSED [ 18%]PASSED [ 19%]PASSED [ 21%]PASSED [ 22%]PASSED [ 24%]PASSED [ 25%]PASSED [ 27%]SKIPPED [ 28%]
Skipped: SSSD was built without support for running under non-root
PASSED [ 30%]SKIPPED [ 31%]
Skipped: SSSD was built without support for running under non-root
PASSED [ 33%]PASSED [ 34%]PASSED [ 36%]PASSED [ 37%]PASSED [ 39%]
tests/test_identity.py::test_identity__lookup_group_membership_by_username_with_id_command[sssd] (ipa) SKIPPED [ 40%]
Skipped: SSSD was built without support for running under non-root

tests/test_identity.py::test_identity__lookup_group_membership_by_group_with_id_command (ipa) PASSED [ 42%]PASSED [ 43%]PASSED [ 45%]PASSED [ 46%]PASSED [ 48%]FAILED [ 50%]

danlavu · 2024-06-26T17:48:21Z

The auto private group tests is fixed.

tests/test_identity.py::test_identity__lookup_when_auto_private_groups_is_set_to_true (ad) 
tests/test_identity.py::test_identity__lookup_when_auto_private_groups_is_set_to_false (ad) 
tests/test_identity.py::test_identity__lookup_when_auto_private_groups_is_set_to_hybrid (ad) 
tests/test_identity.py::test_identity__lookup_when_auto_private_groups_is_set_to_true (ipa) 
tests/test_identity.py::test_identity__lookup_when_auto_private_groups_is_set_to_false (ipa) 
tests/test_identity.py::test_identity__lookup_when_auto_private_groups_is_set_to_hybrid (ipa) 
tests/test_identity.py::test_identity__lookup_when_auto_private_groups_is_set_to_true (ldap) 
tests/test_identity.py::test_identity__lookup_when_auto_private_groups_is_set_to_false (ldap) 
tests/test_identity.py::test_identity__lookup_when_auto_private_groups_is_set_to_hybrid (ldap) 
tests/test_identity.py::test_identity__lookup_when_auto_private_groups_is_set_to_true (samba) 
tests/test_identity.py::test_identity__lookup_when_auto_private_groups_is_set_to_false (samba) 
tests/test_identity.py::test_identity__lookup_when_auto_private_groups_is_set_to_hybrid (samba) PASSED [  8%]PASSED [ 16%]PASSED [ 25%]PASSED [ 33%]PASSED [ 41%]PASSED [ 50%]PASSED [ 58%]PASSED [ 66%]PASSED [ 75%]PASSED [ 83%]PASSED [ 91%]PASSED [100%]

src/tests/system/tests/test_identity.py

jakub-vavra-cz

Please add (back) appropriate error messages to tie the failures with expectedresults.

danlavu · 2024-07-01T12:34:50Z

@jakub-vavra-cz added back

madhuriupadhye

LGTM

src/tests/system/tests/test_identity.py

alexey-tikhonov · 2024-07-24T15:43:33Z

Static code analysis / python-system-tests fails.

danlavu · 2024-07-30T02:56:34Z

@alexey-tikhonov fixed

alexey-tikhonov · 2024-07-30T07:38:25Z

Substantial changes were pushed in https://github.com/SSSD/sssd/compare/2e9ad6b3b29410fa4873212912a47403cc9d9aea..32f423c9f145ccf98718e6419fa139f3a8b7b2ff since last review.

Or was it merely a rebase...

danlavu · 2024-08-02T04:40:08Z

Substantial changes were pushed in https://github.com/SSSD/sssd/compare/2e9ad6b3b29410fa4873212912a47403cc9d9aea..32f423c9f145ccf98718e6419fa139f3a8b7b2ff since last review.

Or was it merely a rebase...

I forgot that the following is required for assertions

assert result is not None, "User not found!"

So, the changes are merely adding it back in to fix the syntax checks.

housekeeping, the following is looked at and may have been done: * fixed typos and standardized formatting * renamed test cases to improve the clarity of what the test does * improved docstring language, setup, steps and expected results * synced code with the docstring order * removed necessary configuration relevant to the test * added pytest.mark.importance to test cases noteable changes: * auto_private_group tests reworked, adding two more test cases

jakub-vavra-cz · 2024-08-19T08:07:13Z

@danlavu :
Conflict in sssd-2-9

danlavu · 2024-08-19T17:01:17Z

@jakub-vavra-cz

Cherry pick
https://github.com/SSSD/sssd/pull/7538/files

jakub-vavra-cz · 2024-08-20T10:52:38Z

Pushed PR: #7461

master
- edb35af - tests: housekeeping, test_identity.py

danlavu added Tests branch: sssd-2-7 branch: sssd-2-8 Work in Progress labels Jun 26, 2024

danlavu self-assigned this Jun 26, 2024

danlavu requested review from madhuriupadhye and aplopez June 26, 2024 11:18

danlavu marked this pull request as draft June 26, 2024 15:15

danlavu force-pushed the tests-housekeeping-identity branch from 0075955 to 3e468e8 Compare June 26, 2024 17:47

danlavu marked this pull request as ready for review June 26, 2024 19:45

danlavu force-pushed the tests-housekeeping-identity branch 2 times, most recently from d7d01cd to 573bedb Compare June 26, 2024 21:03

madhuriupadhye requested changes Jun 27, 2024

View reviewed changes

src/tests/system/tests/test_identity.py Outdated Show resolved Hide resolved

src/tests/system/tests/test_identity.py Outdated Show resolved Hide resolved

src/tests/system/tests/test_identity.py Outdated Show resolved Hide resolved

danlavu force-pushed the tests-housekeeping-identity branch 2 times, most recently from 52e9f51 to cf685f0 Compare June 27, 2024 09:57

jakub-vavra-cz requested changes Jun 27, 2024

View reviewed changes

andreboscatto assigned aplopez, madhuriupadhye and jakub-vavra-cz Jun 27, 2024

danlavu force-pushed the tests-housekeeping-identity branch from cf685f0 to b8597bf Compare June 27, 2024 13:58

danlavu removed the Work in Progress label Jun 27, 2024

danlavu requested a review from madhuriupadhye July 1, 2024 12:35

madhuriupadhye approved these changes Jul 4, 2024

View reviewed changes

aplopez reviewed Jul 4, 2024

View reviewed changes

danlavu force-pushed the tests-housekeeping-identity branch from b8597bf to 8e261cd Compare July 5, 2024 05:00

danlavu requested review from jakub-vavra-cz and aplopez July 5, 2024 19:43

alexey-tikhonov added Changes requested and removed Accepted labels Jul 24, 2024

danlavu force-pushed the tests-housekeeping-identity branch 2 times, most recently from 32f423c to 6a14f4a Compare July 26, 2024 06:01

alexey-tikhonov removed the Changes requested label Jul 30, 2024

danlavu force-pushed the tests-housekeeping-identity branch 2 times, most recently from d339a8e to 156ead4 Compare August 2, 2024 18:38

andreboscatto added Accepted and removed Accepted labels Aug 8, 2024

danlavu added the Accepted label Aug 8, 2024

danlavu force-pushed the tests-housekeeping-identity branch from 156ead4 to 8933006 Compare August 13, 2024 13:10

jakub-vavra-cz added Ready to push Ready to push and removed Ready to push Ready to push labels Aug 19, 2024

jakub-vavra-cz added Ready to push Ready to push and removed Ready to push Ready to push backport-to-stable labels Aug 20, 2024

jakub-vavra-cz added Pushed and removed Accepted Ready to push Ready to push labels Aug 20, 2024

jakub-vavra-cz closed this Aug 20, 2024

danlavu deleted the tests-housekeeping-identity branch November 4, 2024 17:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests: housekeeping, test_identity.py #7461

tests: housekeeping, test_identity.py #7461

danlavu commented Jun 26, 2024 •

edited

Loading

danlavu commented Jun 26, 2024

danlavu commented Jun 26, 2024

jakub-vavra-cz left a comment

danlavu commented Jul 1, 2024

madhuriupadhye left a comment

alexey-tikhonov commented Jul 24, 2024

danlavu commented Jul 30, 2024

alexey-tikhonov commented Jul 30, 2024 •

edited

Loading

danlavu commented Aug 2, 2024 •

edited

Loading

jakub-vavra-cz commented Aug 19, 2024

danlavu commented Aug 19, 2024

jakub-vavra-cz commented Aug 20, 2024

tests: housekeeping, test_identity.py #7461

tests: housekeeping, test_identity.py #7461

Conversation

danlavu commented Jun 26, 2024 • edited Loading

danlavu commented Jun 26, 2024

danlavu commented Jun 26, 2024

jakub-vavra-cz left a comment

Choose a reason for hiding this comment

danlavu commented Jul 1, 2024

madhuriupadhye left a comment

Choose a reason for hiding this comment

alexey-tikhonov commented Jul 24, 2024

danlavu commented Jul 30, 2024

alexey-tikhonov commented Jul 30, 2024 • edited Loading

danlavu commented Aug 2, 2024 • edited Loading

jakub-vavra-cz commented Aug 19, 2024

danlavu commented Aug 19, 2024

jakub-vavra-cz commented Aug 20, 2024

danlavu commented Jun 26, 2024 •

edited

Loading

alexey-tikhonov commented Jul 30, 2024 •

edited

Loading

danlavu commented Aug 2, 2024 •

edited

Loading