-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Fix the test failures for tier-1-pytest-alltests-tier1-2 for n… #7370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborah-sudo
force-pushed
the
non_root_tire1_2
branch
from
May 13, 2024 05:42
b50fd4d
to
88b9465
Compare
madhuriupadhye
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
aborah-sudo
added
Accepted
Ready to push
Ready to push
and removed
Waiting for review
labels
May 14, 2024
alexey-tikhonov
added
Changes requested
and removed
Accepted
Ready to push
Ready to push
Trivial
labels
May 15, 2024
aborah-sudo
force-pushed
the
non_root_tire1_2
branch
2 times, most recently
from
May 15, 2024 10:13
5b6e38a
to
5a2fbcd
Compare
…on root configuration Fix the test failures for tier-1-pytest-alltests-tier1-2 for non root configuration
aborah-sudo
force-pushed
the
non_root_tire1_2
branch
from
May 15, 2024 10:15
5a2fbcd
to
c9cfbc5
Compare
jakub-vavra-cz
approved these changes
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
madhuriupadhye
approved these changes
May 27, 2024
Please set target branches. |
aborah-sudo
added
Accepted
Ready to push
Ready to push
and removed
Waiting for review
labels
May 27, 2024
No backport only master branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on root configuration
Fix the test failures for tier-1-pytest-alltests-tier1-2 for non root configuration