MONITOR: tune startup logic a bit #7365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From test prospective patch is working now |
aborah-sudo
approved these changes
May 13, 2024
so that it is aligned with MONITOR_MAX_SVC_RESTARTS & MONITOR_MAX_RESTART_DELAY
This more or less cosmetic change in the sense that currently this code / condition shouldn't be reachable (see comment in the patch).
|
(rebased) |
pbrezina
approved these changes
May 15, 2024
sumit-bose
approved these changes
May 29, 2024
alexey-tikhonov
added
Accepted
Ready to push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before those patches monitor performed several attempts to start a provider, then started responders, and then quit anyway because all attempt to start a provider were eventually exhausted.
This patch tunes timer so that all attempts to start a provider are exhausted before timer fires (and responders aren't even started).
User visible change is that SSSD now properly notifies systemd that service start failed (instead of reporting it started and then terminated).