Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: explicitly set which topologies are already provisioned #7349

Closed
wants to merge 1 commit into from

Conversation

pbrezina
Copy link
Member

@pbrezina pbrezina commented May 6, 2024

PRCI uses containers that already have multiple topologies provisioned
out of the box. pytest-mh and sssd-test-framework recently got the
ability to provision topology directly from pytest so in order to skip
this step in PRCI we need to set it explicitly.

Note that the client container is currently not enrolled in AD, so we
use topology setup there. Therefore if you run the tests locally with
AD running, you don't have to do a thing - client will automatically
join and leave the AD domain when AD/IPA-TRUST-AD topology is run.


Please note that this needs to be closed together with changes to other repositories:

PRCI uses containers that already have multiple topologies provisioned
out of the box. pytest-mh and sssd-test-framework recently got the
ability to provision topology directly from pytest so in order to skip
this step in PRCI we need to set it explicitly.

Note that the client container is currently not enrolled in AD, so we
use topology setup there. Therefore if you run the tests locally with
AD running, you don't have to do a thing - client will automatically
join and leave the AD domain when AD/IPA-TRUST-AD topology is run.
@justin-stephenson
Copy link
Contributor

Please note that this needs to be closed together with changes to other repositories:

* [topology: provision topologies if not already using per-topology setup sssd-test-framework#103](https://github.com/SSSD/sssd-test-framework/pull/103)

* [provision: do not join domains automatically in Idm CI sssd-ci-containers#95](https://github.com/SSSD/sssd-ci-containers/pull/95)

* [Add support for reentrant utilities to MultihostHost and other improvements next-actions/pytest-mh#54](https://github.com/next-actions/pytest-mh/pull/54)

@pbrezina Will a draft SSSD PR which updates requirements.txt to use these branches be needed to see how these changes may affect SSSD PRCI?

@danlavu
Copy link

danlavu commented May 16, 2024

@pbrezina I'm not sure if we need to make changes to idmci for provisioned_topologies, @jakub-vavra-cz ping

@pbrezina
Copy link
Member Author

pbrezina commented May 17, 2024

@pbrezina I'm not sure if we need to make changes to idmci for provisioned_topologies, @jakub-vavra-cz ping

No, idmci will run the topology controller code. You just want to add the adminpw option:

5579577#diff-58b2cb2530f4c75cc3718794b978b4cdfa5c8138fbf6443c3399468f208aa475R40-R48

@pbrezina
Copy link
Member Author

Please note that this needs to be closed together with changes to other repositories:

* [topology: provision topologies if not already using per-topology setup sssd-test-framework#103](https://github.com/SSSD/sssd-test-framework/pull/103)

* [provision: do not join domains automatically in Idm CI sssd-ci-containers#95](https://github.com/SSSD/sssd-ci-containers/pull/95)

* [Add support for reentrant utilities to MultihostHost and other improvements next-actions/pytest-mh#54](https://github.com/next-actions/pytest-mh/pull/54)

@pbrezina Will a draft SSSD PR which updates requirements.txt to use these branches be needed to see how these changes may affect SSSD PRCI?

We can do it if you want, but you can run it locally so it should not be strictly needed.

Copy link
Contributor

@justin-stephenson justin-stephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, thank you.

@pbrezina
Copy link
Member Author

Pushed PR: #7349

  • master
    • b026d62 - ci: explicitly set which topologies are already provisioned
  • sssd-2-8
    • 065cd39 - ci: explicitly set which topologies are already provisioned
  • sssd-2-9
    • d29e401 - ci: explicitly set which topologies are already provisioned

@pbrezina pbrezina added Pushed and removed Accepted Ready to push Ready to push labels May 28, 2024
@pbrezina pbrezina closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants