-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: explicitly set which topologies are already provisioned #7349
Conversation
PRCI uses containers that already have multiple topologies provisioned out of the box. pytest-mh and sssd-test-framework recently got the ability to provision topology directly from pytest so in order to skip this step in PRCI we need to set it explicitly. Note that the client container is currently not enrolled in AD, so we use topology setup there. Therefore if you run the tests locally with AD running, you don't have to do a thing - client will automatically join and leave the AD domain when AD/IPA-TRUST-AD topology is run.
@pbrezina Will a draft SSSD PR which updates |
@pbrezina I'm not sure if we need to make changes to idmci for provisioned_topologies, @jakub-vavra-cz ping |
No, idmci will run the topology controller code. You just want to add the adminpw option: 5579577#diff-58b2cb2530f4c75cc3718794b978b4cdfa5c8138fbf6443c3399468f208aa475R40-R48 |
We can do it if you want, but you can run it locally so it should not be strictly needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, thank you.
PRCI uses containers that already have multiple topologies provisioned
out of the box. pytest-mh and sssd-test-framework recently got the
ability to provision topology directly from pytest so in order to skip
this step in PRCI we need to set it explicitly.
Note that the client container is currently not enrolled in AD, so we
use topology setup there. Therefore if you run the tests locally with
AD running, you don't have to do a thing - client will automatically
join and leave the AD domain when AD/IPA-TRUST-AD topology is run.
Please note that this needs to be closed together with changes to other repositories: