-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUILD: make support of 'sssd.conf::user' option configurable #7308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-tikhonov
force-pushed
the
conditional-sssd-user
branch
2 times, most recently
from
April 23, 2024 09:47
236da8a
to
31054ff
Compare
alexey-tikhonov
requested review from
justin-stephenson,
sumit-bose and
pbrezina
April 23, 2024 09:48
sumit-bose
reviewed
Apr 23, 2024
alexey-tikhonov
force-pushed
the
conditional-sssd-user
branch
from
April 23, 2024 13:57
31054ff
to
6b2c443
Compare
pbrezina
approved these changes
Apr 25, 2024
:relnote:Support of 'sssd.conf::user' option was made build time configurable ('--with-conf-service-user-support') and disabled by default. Take a note that this ./configure option only makes sense if used together with '--with-sssd-user=...' Support of this option is deprecated and might be removed in future releases. Recommended way to configure SSSD service user is to simply start main SSSD process under required user (made available at build time using '--with-sssd-user=...')
alexey-tikhonov
force-pushed
the
conditional-sssd-user
branch
from
April 25, 2024 14:17
6b2c443
to
4bd27ef
Compare
justin-stephenson
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, thank you.
sumit-bose
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
patch is working for me, ACK.
bye,
Sumit
alexey-tikhonov
added
Accepted
Ready to push
Ready to push
and removed
Waiting for review
Ready to push
Ready to push
labels
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:relnote:Support of 'sssd.conf::user' option was made build time
configurable ('--with-conf-service-user-support') and disabled by
default. Take a note that this ./configure option only makes sense
if used together with '--with-sssd-user=...'
Support of this option is deprecated and might be removed in future
releases. Recommended way to configure SSSD service user is to simply
start main SSSD process under required user (made available at build
time using '--with-sssd-user=...')