dist: set capabilities during make install

[sumit-bose]

No description provided.

[alexey-tikhonov]

Btw, @justin-stephenson also hit this issue (of missing caps after 'make install') during his work.

[alexey-tikhonov]

Besides file capabilities of child helpers, also ownership and/or access mode of some /var/lib/sss/... dirs changed in spec-file and wasn't reflected in 'make install', I guess.

[alexey-tikhonov]

And maybe also add 'Resolves: #7284'?

[sumit-bose]

Besides file capabilities of child helpers, also ownership and/or access mode of some /var/lib/sss/... dirs changed in spec-file and wasn't reflected in 'make install', I guess.

Hi,

there already is SSSD_USER_DIRS in Makefile.am which should take care of this.

bye,
Sumit

[sumit-bose]

And maybe also add 'Resolves: #7284'?

Thanks, added in the latest version.

[sumit-bose]

Hi,

I used make distcheck to test make install. The second patch contains fixed to make make disctcheck work again.

bye,
Sumit

[sumit-bose]

Hi,

I used make distcheck to test make install. The second patch contains fixed to make make disctcheck work again.

bye, Sumit

I removed the second patch because it is currently breaking copr builds.

[alexey-tikhonov]

Besides file capabilities of child helpers, also ownership and/or access mode of some /var/lib/sss/... dirs changed in spec-file and wasn't reflected in 'make install', I guess.

Hi,

there already is SSSD_USER_DIRS in Makefile.am which should take care of this.

There is, but I forgot about it while updating 'sssd.spec.in' (changing ownership and access mode of some dirs) so I'm pretty sure there are some discrepancies currently. I'm composing the list...

[alexey-tikhonov]

Mismatch identified so far:

• missing group access to /var/log/sssd, /var/lib/sss/db, keytabs,
• missing group write access to deskprofile, gpo_cache, mc, pipes, pubconf
• SSSD ownership and access mode of '/var/lib/sss' itself

I just compared results of 'make install' from this PR and installed recent copr build.

[justin-stephenson]

Ack, thank you.

[alexey-tikhonov]

@sumit-bose , I tried to build from sources on Rawhide and everything looks fine besides /var/lib/sss folder itself:

drwxrwxr-x. 10 root    root    4096 Apr 25 09:55 sss

I guess $(sss_statedir) should be added to SSSD_USER_DIRS as well?

[sumit-bose]

@sumit-bose , I tried to build from sources on Rawhide and everything looks fine besides /var/lib/sss folder itself:

drwxrwxr-x. 10 root    root    4096 Apr 25 09:55 sss

I guess $(sss_statedir) should be added to SSSD_USER_DIRS as well?

Hi,

of course you are right, fixed in the latest version.

bye,
Sumit

[alexey-tikhonov]

Thank you, ACK.

[alexey-tikhonov]

Pushed PR: #7292

• master
  • 1199bd1 - conf: update path permissions
  • 7239dd6 - dist: set capabilities during make install