TESTS: don't use deprecated sssd.conf::user option #7266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-tikhonov
added
no-backport
jakub-vavra-cz
requested changes
Apr 2, 2024
Currently when SSSD is built '--with-sssd-user=sssd' it's also configured to run under 'sssd' user by default via sssd.service, so that sssd.conf::user option is ignored anyway. Since sssd.conf::user is deprecated and will go away, it doesn't make much sense to put effort into testing it. What makes sense is to test sssd.service::User option, but this is out of scope of this patch.
alexey-tikhonov
force-pushed
the
non-root-tests
branch
from
4b79fe6 to
650f7df
Compare
|
LGTM. |
jakub-vavra-cz
approved these changes
Apr 3, 2024
|
I realized it might make sense to change implementation of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when SSSD is built '--with-sssd-user=sssd' it's also configured to run under 'sssd' user by default via sssd.service, so that sssd.conf::user option is ignored anyway.
Since sssd.conf::user is deprecated and will go away, it doesn't make much sense to put effort into testing it.
What makes sense is to test sssd.service::User option, but this is out of scope of this patch.