Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ad: refresh root domain when read directly #7251

Closed
wants to merge 1 commit into from

Conversation

sumit-bose
Copy link
Contributor

If the domain object of the forest root domain cannot be found in the
LDAP tree of the local AD domain SSSD tries to read the request data
from an LDAP server of the forest root domain directly. After reading
this data the information is stored in the cache but currently the
information about the domain store in memory is not updated with the
additional data. As a result e.g. the domain SID is missing in this data
and only becomes available after a restart where it is read from the
cache.

With this patch an unconditional refresh is triggered at the end of the
fallback code path.

Resolves: #7250

Copy link
Contributor

@thalman thalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the patch

Copy link

@danlavu danlavu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

@alexey-tikhonov alexey-tikhonov added Ready to push Ready to push and removed Ready to push Ready to push labels Apr 22, 2024
@alexey-tikhonov
Copy link
Member

@sumit-bose, could you please rebase?

If the domain object of the forest root domain cannot be found in the
LDAP tree of the local AD domain SSSD tries to read the request data
from an LDAP server of the forest root domain directly. After reading
this data the information is stored in the cache but currently the
information about the domain store in memory is not updated with the
additional data. As a result e.g. the domain SID is missing in this data
and only becomes available after a restart where it is read from the
cache.

With this patch an unconditional refresh is triggered at the end of the
fallback code path.

Resolves: SSSD#7250
@sumit-bose sumit-bose force-pushed the missing_root_dom_sid branch from c8115e9 to 4c66508 Compare April 23, 2024 08:23
@sumit-bose
Copy link
Contributor Author

@sumit-bose, could you please rebase?

done

@alexey-tikhonov alexey-tikhonov added the Ready to push Ready to push label Apr 23, 2024
@alexey-tikhonov
Copy link
Member

Pushed PR: #7251

  • master
    • 0de6c33 - ad: refresh root domain when read directly
  • sssd-2-9
    • db27a51 - ad: refresh root domain when read directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSSD is not fully registering the domains if the cache is empty
4 participants