Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: adding gpo system tests #7249

Closed
wants to merge 1 commit into from
Closed

tests: adding gpo system tests #7249

wants to merge 1 commit into from

Conversation

danlavu
Copy link

@danlavu danlavu commented Mar 19, 2024

No description provided.

@danlavu danlavu marked this pull request as draft March 19, 2024 07:59
@danlavu danlavu force-pushed the gpo branch 2 times, most recently from d05fade to 0c9a69b Compare March 26, 2024 00:56
@danlavu danlavu force-pushed the gpo branch 3 times, most recently from ebf3d8b to 3ad625f Compare March 26, 2024 04:25
@danlavu danlavu changed the title tests: adding gpo tests from downstream tests: adding gpo system tests Mar 26, 2024
@danlavu danlavu force-pushed the gpo branch 3 times, most recently from eba52b1 to 28184b4 Compare March 26, 2024 05:14
@danlavu danlavu force-pushed the gpo branch 4 times, most recently from 4af7312 to 915c5dd Compare March 27, 2024 00:51
@danlavu danlavu self-assigned this Mar 27, 2024
@danlavu danlavu added the Tests label Mar 27, 2024
@danlavu
Copy link
Author

danlavu commented Mar 27, 2024

@sumit-bose whenever you get a chance, can you review the test cases / doc strings before we write the test cases?

@danlavu danlavu force-pushed the gpo branch 2 times, most recently from 9fe1222 to a60d3e0 Compare March 31, 2024 22:35
@danlavu
Copy link
Author

danlavu commented Apr 1, 2024 

============================= test session starts ==============================
collecting ... 

Selected tests will use the following hosts:
 client: client.test
 ad: dc.ad.test
 nfs: nfs.test

collected 30 items

tests/test_gpo.py::test_gpo__is_set_to_enforcing[root] (ad) 
tests/test_gpo.py::test_gpo__is_set_to_enforcing[sssd] (ad) 
tests/test_gpo.py::test_gpo__is_set_to_enforcing_with_no_policy[root] (ad) 
tests/test_gpo.py::test_gpo__is_set_to_enforcing_with_no_policy[sssd] (ad) 
tests/test_gpo.py::test_gpo__is_set_to_permissive[root] (ad) 
tests/test_gpo.py::test_gpo__is_set_to_permissive[sssd] (ad) 
tests/test_gpo.py::test_gpo__is_set_to_disabled[root] (ad) 
tests/test_gpo.py::test_gpo__is_set_to_disabled[sssd] (ad) 
tests/test_gpo.py::test_gpo__implicit_deny_is_set_to_true[root] (ad) 
tests/test_gpo.py::test_gpo__implicit_deny_is_set_to_true[sssd] (ad) 
tests/test_gpo.py::test_gpo__ou_over_domain_over_sites_inheritance[root] (ad) 
tests/test_gpo.py::test_gpo__ou_over_domain_over_sites_inheritance[sssd] (ad) 
tests/test_gpo.py::test_gpo__site_over_domain_over_ou_inheritance_using_gpo_link_order[root] (ad) 
tests/test_gpo.py::test_gpo__site_over_domain_over_ou_inheritance_using_gpo_link_order[sssd] (ad) 
tests/test_gpo.py::test_gpo__map_interactive_disabling_login_su_and_su_l[root] (ad) 
tests/test_gpo.py::test_gpo__map_interactive_disabling_login_su_and_su_l[sssd] (ad) 
tests/test_gpo.py::test_gpo__map_remote_interactive_disabling_sshd[root] (ad) 
tests/test_gpo.py::test_gpo__map_remote_interactive_disabling_sshd[sssd] (ad) 
tests/test_gpo.py::test_gpo__works_when_the_server_is_unreachable[root] (ad) 
tests/test_gpo.py::test_gpo__works_when_the_server_is_unreachable[sssd] (ad) 
tests/test_gpo.py::test_gpo__honors_the_ad_site_parameter[root] (ad) 
tests/test_gpo.py::test_gpo__only_needs_host_security_filters_and_permissions[sssd] (ad) 
tests/test_gpo.py::test_gpo__ignores_invalid_and_unnecessary_keys_and_values[root] (ad) 
tests/test_gpo.py::test_gpo__ignores_invalid_and_unnecessary_keys_and_values[sssd] (ad) 
tests/test_gpo.py::test_gpo__skips_unreadable_gpo_policies[root] (ad) 
tests/test_gpo.py::test_gpo__skips_unreadable_gpo_policies[sssd] (ad) 
tests/test_gpo.py::test_gpo__works_when_auto_private_groups_is_set_true[root] (ad) 
tests/test_gpo.py::test_gpo__works_when_auto_private_groups_is_set_true[sssd] (ad) 

================== 13 passed, 17 skipped in 369.33s (0:06:09) ==================
PASSED       [  3%]SKIPPED      [  6%]
Skipped: SSSD was built without support for running under non-root
PASSED [ 10%]SKIPPED [ 13%]
Skipped: SSSD was built without support for running under non-root
PASSED      [ 16%]SKIPPED     [ 20%]
Skipped: SSSD was built without support for running under non-root
PASSED        [ 23%]SKIPPED (SSSD
was built without support for running under non-root)                    [ 26%]
Skipped: SSSD was built without support for running under non-root
PASSED [ 30%]SKIPPED [ 33%]
Skipped: SSSD was built without support for running under non-root
PASSED [ 36%]SKIPPED [ 40%]
Skipped: SSSD was built without support for running under non-root
PASSED [ 43%]SKIPPED [ 46%]
Skipped: SSSD was built without support for running under non-root
PASSED [ 50%]SKIPPED [ 53%]
Skipped: SSSD was built without support for running under non-root
PASSED [ 56%]SKIPPED [ 60%]
Skipped: SSSD was built without support for running under non-root
PASSED [ 63%]SKIPPED [ 66%]
Skipped: SSSD was built without support for running under non-root
SKIPPED [ 70%]
Skipped: unconditional skip

tests/test_gpo.py::test_gpo__honors_the_ad_site_parameter[sssd] (ad) SKIPPED [ 73%]
Skipped: unconditional skip

tests/test_gpo.py::test_gpo__only_needs_host_security_filters_and_permissions[root] (ad) PASSED [ 76%]SKIPPED [ 80%]
Skipped: SSSD was built without support for running under non-root
PASSED [ 83%]SKIPPED [ 86%]
Skipped: SSSD was built without support for running under non-root
PASSED [ 90%]SKIPPED [ 93%]
Skipped: SSSD was built without support for running under non-root
SKIPPED [ 96%]
Skipped: unconditional skip
SKIPPED [100%]
Skipped: unconditional skip

Process finished with exit code 0

@danlavu danlavu restored the gpo branch April 18, 2024 17:07
@danlavu
Copy link
Author

danlavu commented Apr 18, 2024

My IDE accidentally pruned this branch.

@danlavu danlavu reopened this Apr 18, 2024
@danlavu danlavu force-pushed the gpo branch 4 times, most recently from 1cb8e2a to fbb43a1 Compare April 24, 2024 04:22
@danlavu
Copy link
Author

danlavu commented May 8, 2024

@sumit-bose I think everything is addressed, approved?

sumit-bose
sumit-bose approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@sumit-bose sumit-bose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

thanks for the updates, no further comments, ACK.

bye,
Sumit

@pbrezina
Copy link
Member

pbrezina commented May 9, 2024

Pushed PR: #7249

  • master
    • 7f48c7c - tests: adding gpo system tests
  • sssd-2-8
    • 84eb979 - tests: adding gpo system tests
  • sssd-2-9
    • 7d260f7 - tests: adding gpo system tests

@pbrezina pbrezina added Pushed and removed Accepted Ready to push Ready to push labels May 9, 2024
@pbrezina pbrezina closed this May 9, 2024
@danlavu danlavu deleted the gpo branch July 8, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakub-vavra-cz jakub-vavra-cz jakub-vavra-cz left review comments

@sumit-bose sumit-bose sumit-bose approved these changes

Assignees

@sumit-bose sumit-bose

@jakub-vavra-cz jakub-vavra-cz

Labels
branch: sssd-2-8 Pushed Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danlavu @jakub-vavra-cz @pbrezina @sumit-bose @andreboscatto