-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TESTS: Fix the ssh configuration - II #7247
Conversation
c3966dc
to
5613258
Compare
The previous patch fixed the environment for the multihost tests, but system tests also need the fix. This fix will become obsolete and should be removed when FreeIPA adapts the ipa-client-install tool to use the sss_ssh_knownhosts tool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is workaround that will be removed soon, I'm fine with that.
Otherwise I would appreciate better regex like s/^Global...
Also with sed you can use any character in expression as a separator so it is then more readable (You do not have to escape all backslashes - like -e 's#/etc/#/opt/etc/#')
ACK
Me too, but that expression would not work. FreeIPA generates the
Nice! I didn't know this. Thanks. |
The previous patch fixed the environment for the multihost tests, but system tests also need the fix.
Previous patch: e556bfd
These two patches need to be removed once FreeIPA has updated their tool
ipa-client-install
to use our new toolsss_ssh_knownhosts
.FreeIPA's PR: freeipa/freeipa#7254