Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TESTS: Fix the ssh configuration - II #7247

Closed
wants to merge 1 commit into from

Conversation

aplopez
Copy link
Contributor

@aplopez aplopez commented Mar 18, 2024

The previous patch fixed the environment for the multihost tests, but system tests also need the fix.

Previous patch: e556bfd

These two patches need to be removed once FreeIPA has updated their tool ipa-client-install to use our new tool sss_ssh_knownhosts.

FreeIPA's PR: freeipa/freeipa#7254

@alexey-tikhonov alexey-tikhonov added the no-backport This should go to target branch only. label Mar 18, 2024
@aplopez aplopez force-pushed the known-hosts branch 5 times, most recently from c3966dc to 5613258 Compare March 18, 2024 14:33
The previous patch fixed the environment for the multihost tests, but
system tests also need the fix.

This fix will become obsolete and should be removed when FreeIPA
adapts the ipa-client-install tool to use the sss_ssh_knownhosts tool.
@aplopez aplopez marked this pull request as ready for review March 18, 2024 16:32
@aplopez aplopez requested a review from alexey-tikhonov March 18, 2024 16:32
@alexey-tikhonov alexey-tikhonov self-assigned this Mar 18, 2024
@thalman thalman self-assigned this Mar 19, 2024
@thalman thalman self-requested a review March 19, 2024 13:35
Copy link
Contributor

@thalman thalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is workaround that will be removed soon, I'm fine with that.

Otherwise I would appreciate better regex like s/^Global...

Also with sed you can use any character in expression as a separator so it is then more readable (You do not have to escape all backslashes - like -e 's#/etc/#/opt/etc/#')

ACK

@aplopez
Copy link
Contributor Author

aplopez commented Mar 21, 2024

Since this is workaround that will be removed soon, I'm fine with that.

Otherwise I would appreciate better regex like s/^Global...

Me too, but that expression would not work. FreeIPA generates the GlobalKnownHostsFile line indented because it is preceded by another one to which it is related. Not using the ^ guarantees it will match wherever it is placed in the line.

Also with sed you can use any character in expression as a separator so it is then more readable (You do not have to escape all backslashes - like -e 's#/etc/#/opt/etc/#')

Nice! I didn't know this. Thanks.

@alexey-tikhonov
Copy link
Member

Pushed PR: #7247

  • master
    • c858d57 - TESTS: Fix the ssh configuration - II

@aplopez aplopez deleted the known-hosts branch March 26, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport This should go to target branch only. Pushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants