-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COMPONENT: sdap_idmap #7239
Closed
Closed
COMPONENT: sdap_idmap #7239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roy214
force-pushed
the
idmap_debug
branch
2 times, most recently
from
March 13, 2024 11:06
a97cb63
to
b77f8d8
Compare
sumit-bose
reviewed
Mar 13, 2024
Roy214
force-pushed
the
idmap_debug
branch
3 times, most recently
from
March 13, 2024 19:44
ba9c9c1
to
9a6c398
Compare
sumit-bose
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
thank you for the patch, this is a useful addition, ACK.
bye,
Sumit
Thanks @sumit-bose @alexey-tikhonov |
alexey-tikhonov
added
Accepted
Ready to push
Ready to push
and removed
Waiting for review
labels
Mar 14, 2024
Hi, can you please change the commit message? The COMPONENT word should be replaced with the component, followed by brief description of the changes. |
…ng reason for Could not convert objectSID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling further debugging to understand the underlying reason for Could not convert objectSID