Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: passkey: Add a ssh key as a passkey mapping #7207

Closed
wants to merge 1 commit into from
Closed

Tests: passkey: Add a ssh key as a passkey mapping #7207

wants to merge 1 commit into from

Conversation

madhuriupadhye
Copy link
Contributor

@madhuriupadhye madhuriupadhye commented Feb 22, 2024 •
edited
Loading 

Here, added two test cases:
1. Check log message when we add ssh key as passkey
mapping.
2. Check log message when we add ssh key with
passkey token.

@madhuriupadhye madhuriupadhye added Waiting for review Tests backport-to-stable passkey Issues and PRs related to 'passkey' feature labels Feb 22, 2024
@andreboscatto andreboscatto requested review from ikerexxe and removed request for justin-stephenson February 22, 2024 13:47
ikerexxe
ikerexxe requested changes Feb 27, 2024
View reviewed changes
src/tests/system/tests/test_passkey.py Show resolved Hide resolved
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
spoore1
spoore1 reviewed Feb 29, 2024
View reviewed changes
Copy link
Contributor

@spoore1 spoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a general question about the test and possibly a suggestion for additional tests:

Isn't the main point that SSH/SU should work with non-passkey mapping data stored in the provider when passkey feature is enabled?

Should we also cover the following scenarios?

  1. Mixed passkey and non-passkey data in the provider attribute
  2. SSH with passkey data in the provider attribute? (does this work properly now?)
  3. SSH with password if passkey data is in the provider attribute
  4. SSH with public key if ssh key is stored in the provider attribute (this one might be better in another test suite)?

src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
ikerexxe
ikerexxe reviewed Mar 11, 2024
View reviewed changes
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
spoore1
spoore1 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@spoore1 spoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@madhuriupadhye madhuriupadhye requested a review from ikerexxe March 21, 2024 07:20
@madhuriupadhye madhuriupadhye force-pushed the ssh_passkey branch 3 times, most recently from b20c33d to f3788e1 Compare April 5, 2024 11:20
spoore1
spoore1 reviewed Apr 5, 2024
View reviewed changes
Copy link
Contributor

@spoore1 spoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 codeQL warning and a couple of suggestions for test case naming changes that might clarify test purposes.

src/tests/system/tests/test_passkey.py Fixed Show resolved Hide resolved
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved
@spoore1 spoore1 self-requested a review April 5, 2024 14:36
@justin-stephenson justin-stephenson self-assigned this Apr 5, 2024
@justin-stephenson justin-stephenson self-requested a review April 5, 2024 14:51
@madhuriupadhye madhuriupadhye force-pushed the ssh_passkey branch 5 times, most recently from eb70793 to 7d2e48c Compare April 10, 2024 14:51
@madhuriupadhye
Tests: passkey: Add a ssh key as a passkey mapping
d2316d5 
Here, added two test cases:
1. Check log message when we add ssh key as passkey
mapping.
2. Check log message when we add ssh key with
passkey token.

Signed-off-by: Madhuri Upadhye <[email protected]>
spoore1
spoore1 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@spoore1 spoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ikerexxe
ikerexxe approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

justin-stephenson
justin-stephenson approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@justin-stephenson justin-stephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, thank you.

@alexey-tikhonov alexey-tikhonov added the Ready to push Ready to push label Apr 22, 2024
@alexey-tikhonov
Copy link
Member

Pushed PR: #7207

  • master
    • 55bcb88 - Tests: passkey: Add a ssh key as a passkey mapping
  • sssd-2-9
    • c9977ca - Tests: passkey: Add a ssh key as a passkey mapping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumit-bose sumit-bose sumit-bose left review comments

@abbra abbra abbra left review comments

@justin-stephenson justin-stephenson justin-stephenson approved these changes

@spoore1 spoore1 spoore1 approved these changes

@ikerexxe ikerexxe ikerexxe approved these changes

@pbrezina pbrezina Awaiting requested review from pbrezina

Assignees

@ikerexxe ikerexxe

@spoore1 spoore1

@justin-stephenson justin-stephenson

Labels
passkey Issues and PRs related to 'passkey' feature Pushed Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@madhuriupadhye @alexey-tikhonov @abbra @ikerexxe @spoore1 @justin-stephenson @sumit-bose @pbrezina