Stig ipa #7070
Closed
Stig ipa #7070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhuriupadhye
force-pushed
the
stig_ipa
branch
from
247c469 to
12a96d2
Compare
Reviewed-by: Justin Stephenson <[email protected]> Reviewed-by: Pavel Březina <[email protected]> Reviewed-by: Sumit Bose <[email protected]> Signed-off-by: Madhuri Upadhye <[email protected]>
madhuriupadhye
force-pushed
the
stig_ipa
branch
3 times, most recently
from
2966a59 to
c4f2122
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+226
to
+227
| # with pytest.raises(subprocess.CalledProcessError): | ||
| # client.run_command("grep subid /etc/nsswitch.conf") |
Check notice
Code scanning / CodeQL
Commented-out code Note test
There was a problem hiding this comment.
Why was it here and why is it being removed?
There was a problem hiding this comment.
I don't know why it was here.
I removed for two reasons:
- While checking it always comes with exit code as a 1, with stig and non-stig also.
- There is no thread running, but with thread error code enters in deadlock and stuck there.
2023-12-08 10:12:27,123 - sssd.testlib.common.qe_class.QeHost.client.cmd412 - DEBUG - RUN grep subid /etc/nsswitch.conf
^C
Program interrupted. (Use 'cont' to resume).
> /usr/lib64/python3.11/threading.py(1133)_wait_for_tstate_lock()
-> lock.release()
If we need to add them better we add with regex but not with grep command.
Signed-off-by: Madhuri Upadhye <[email protected]>
madhuriupadhye
force-pushed
the
stig_ipa
branch
from
c4f2122 to
c7ca4b0
Compare
| @@ -39,7 +39,7 @@ def ipa_subid_find(multihost): | |||
| @pytest.mark.usefixtures('environment_setup', | |||
| 'subid_generate', | |||
| 'bkp_cnfig_for_subid_files') | |||
| @pytest.mark.tier1 | |||
| @pytest.mark.tier4 | |||
There was a problem hiding this comment.
Just for testing, will update once changes in test looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.