Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: build passkey for centos-9 #6998

Closed
wants to merge 1 commit into from
Closed

CI: build passkey for centos-9 #6998

wants to merge 1 commit into from

Conversation

ikerexxe
Copy link
Contributor

No description provided.

@ikerexxe ikerexxe marked this pull request as draft October 24, 2023 10:29
@alexey-tikhonov alexey-tikhonov self-assigned this Oct 24, 2023
@alexey-tikhonov
Copy link
Member

Let's also fix

sssd/contrib/sssd.spec.in

Line 40 in 6814b27

%if 0%{?fedora} >= 39

Spec file will be pulled into RHEL10 via Fedora ELN.

@alexey-tikhonov
Copy link
Member

Not needed to fix CI issue, but I'd suggest to take opportunity to clean up entire configure.sh:

  • we don't run CI for RHEL/CentOS 6/7
  • -redhat-fedora-2[0-2]* also can be removed
  • everywhere centos-9 is used it makes sense to add 10 as well
  • 'subid' support should be enabled for F40>=0 as well (probably can be merged into "--without-python2-bindings" because we already don't care about Fedora older than 35)

@alexey-tikhonov
Copy link
Member

Not needed to fix CI issue, but I'd suggest to take opportunity to clean up entire configure.sh

But if you wouldn't like to address above list in this PR, then ACK.

aplopez
aplopez reviewed Oct 24, 2023
View reviewed changes
contrib/ci/configure.sh Outdated Show resolved Hide resolved
@spoore1 spoore1 mentioned this pull request Oct 24, 2023
Closed
@ikerexxe
CI: build passkey for centos-9
b4d4059 
Also include RHEL9+ to build passkey in the spec file.

Signed-off-by: Iker Pedrosa <[email protected]>
@ikerexxe
Copy link
Contributor Author

Not needed to fix CI issue, but I'd suggest to take opportunity to clean up entire configure.sh:

* we don't run CI for RHEL/CentOS 6/7

* `-redhat-fedora-2[0-2]*` also can be removed

* everywhere centos-9 is used it makes sense to add 10 as well

* 'subid' support should be enabled for F40>=0 as well (probably can be merged into "--without-python2-bindings" because we already don't care about Fedora older than 35)

I think it's better to fix this in another PR.

@ikerexxe ikerexxe mentioned this pull request Oct 25, 2023
Closed
@ikerexxe ikerexxe marked this pull request as ready for review October 25, 2023 08:56
@ikerexxe
Copy link
Contributor Author

CI failures are unrelated

@alexey-tikhonov
Copy link
Member

@aplopez, are you fine with current version?

aplopez
aplopez approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@aplopez aplopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Thanks

@alexey-tikhonov
Copy link
Member

Pushed PR: #6998

  • master
    • 5a211ec - CI: build passkey for centos-9
  • sssd-2-9
    • fa33c99 - CI: build passkey for centos-9

@ikerexxe ikerexxe deleted the passkey_ci branch October 25, 2023 14:03
@ikerexxe ikerexxe mentioned this pull request Oct 27, 2023
Closed
@alexey-tikhonov alexey-tikhonov mentioned this pull request Nov 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-tikhonov alexey-tikhonov alexey-tikhonov approved these changes

@aplopez aplopez aplopez approved these changes

Assignees

@aplopez aplopez

@alexey-tikhonov alexey-tikhonov

Labels
Pushed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikerexxe @alexey-tikhonov @aplopez