Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump DamianReeves/write-file-action from 41569a7dac64c252caacca7bceefe28b70b38db1 to 0a7fcbe1960c53fc08fe789fa4850d24885f4d84 #6995

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 23, 2023

Bumps DamianReeves/write-file-action from 41569a7dac64c252caacca7bceefe28b70b38db1 to 0a7fcbe1960c53fc08fe789fa4850d24885f4d84.

Commits
  • 0a7fcbe Overwritten by Github Actions - ${date}
  • afb5d1d Merge 9fb3fde1cf18fb03705b93e687c5261dc6890b41 into 1d0220365f3fbb2899fcee385...
  • 9fb3fde Update actions version
  • 564b11b Updates
  • 1d02203 Overwritten by Github Actions - ${date}
  • 2cb478b Update node version
  • a432935 Overwritten by Github Actions - ${date}
  • e139b94 Merge ce03f9e984d26aefbb2b8796b661fd724440f4ad into fbc1a1ac95c85dbf087f0dd30...
  • ce03f9e Change file created by test
  • fbc1a1a Overwritten by Github Actions - ${date}
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [DamianReeves/write-file-action](https://github.com/damianreeves/write-file-action) from 41569a7dac64c252caacca7bceefe28b70b38db1 to 0a7fcbe1960c53fc08fe789fa4850d24885f4d84.
- [Release notes](https://github.com/damianreeves/write-file-action/releases)
- [Commits](DamianReeves/write-file-action@41569a7...0a7fcbe)

---
updated-dependencies:
- dependency-name: DamianReeves/write-file-action
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 23, 2023
@justin-stephenson justin-stephenson self-assigned this Oct 23, 2023
@justin-stephenson
Copy link
Contributor

@pbrezina Do you remember why we used a certain commit hash for this GH action?

      uses: DamianReeves/write-file-action@41569a7dac64c252caacca7bceefe28b70b38db1

Can we instead switch to this?

      uses: DamianReeves/[email protected]

@pbrezina
Copy link
Member

It is recommended to use hashes for external actions that you do not trust. If you use tag, it can be deleted and added again to different hash. So if someone re-tags it to malicious code, it will affect our workflow.

But yes, we can use tag in this line since no secrets are available for this workflow (pull_request), we should not use it for pull_request_target.

@justin-stephenson
Copy link
Contributor

It is recommended to use hashes for external actions that you do not trust. If you use tag, it can be deleted and added again to different hash. So if someone re-tags it to malicious code, it will affect our workflow.

But yes, we can use tag in this line since no secrets are available for this workflow (pull_request), we should not use it for pull_request_target.

Okay makes sense, let's leave this PR as is and just bump the commit hash to follow recommended security practices.

@pbrezina
Copy link
Member

Pushed PR: #6995

  • master
    • 0456eca - build(deps): bump DamianReeves/write-file-action
  • sssd-2-9
    • 9ebaee7 - build(deps): bump DamianReeves/write-file-action

@pbrezina pbrezina added Pushed and removed Accepted Ready to push Ready to push labels Oct 26, 2023
@pbrezina pbrezina closed this Oct 26, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 26, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/github_actions/DamianReeves/write-file-action-0a7fcbe1960c53fc08fe789fa4850d24885f4d84 branch October 26, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Pushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants