man: clarify user credentials for cache_credentials
#6989
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/man/sssd.conf.5.xml
Outdated
| @@ -2928,7 +2928,8 @@ pam_gssapi_indicators_map = sudo:pkinit, sudo-i:pkinit | |||
| <listitem> | |||
| <para> | |||
| Determines if user credentials are also cached | |||
| in the local LDB cache. | |||
| in the local LDB cache. The user credentials refer | |||
There was a problem hiding this comment.
s/user/cached/ sounds a bit better IMO but I don't insist.
justin-stephenson
approved these changes
Oct 19, 2023
sumit-bose
reviewed
Oct 19, 2023
src/man/sssd.conf.5.xml
Outdated
| @@ -2928,7 +2928,8 @@ pam_gssapi_indicators_map = sudo:pkinit, sudo-i:pkinit | |||
| <listitem> | |||
| <para> | |||
| Determines if user credentials are also cached | |||
| in the local LDB cache. | |||
| in the local LDB cache. The user credentials refer | |||
| to passwords, not other authentication mechanisms. | |||
There was a problem hiding this comment.
Hi,
I'd like to suggest to add ... refer to passwords, which includes the first (long term) factor of two-factor authentication, not other ..... And Passkey and Smartcard authentications are expected to work offline as long as a successful online authentication is recorded in the cache without additional configuration.
bye,
Sumit
There was a problem hiding this comment.
Updated following your comments
It only applies to passwords, not other authentication mechanisms like smartcards or passkeys. Signed-off-by: Iker Pedrosa <[email protected]>
ikerexxe
force-pushed
the
man_cache_credentials
branch
from
0f0bbfd to
47c1912
Compare
sumit-bose
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It only applies to passwords, not other authentication mechanisms like smartcards or passkeys.