BUILD: get rid of --with-semanage ./configure switch
#6961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-tikhonov
added
Waiting for review
no-backport
alexey-tikhonov
force-pushed
the
no-selinux
branch
2 times, most recently
from
ffe0663 to
d0888c2
Compare
aplopez
reviewed
Sep 28, 2023
| @@ -459,7 +456,7 @@ int sss_del_seuser(const char *login_name) | |||
| sss_semanage_close(handle); | |||
| return ret; | |||
| } | |||
| #else /* HAVE_SEMANAGE && HAVE_SELINUX */ | |||
There was a problem hiding this comment.
I think the comment should not be removed, but modified to reflect the new situation (/* HAVE_SELINUX */). This else is about 400 lines away from its corresponding if, making it hard to know at a single glance what it is doing.
justin-stephenson
approved these changes
Sep 28, 2023
:relnote:Explicit `--with-semanage` ./configure switch was removed, going forward `--with-selinux` includes this. Resolves: SSSD#6647
alexey-tikhonov
force-pushed
the
no-selinux
branch
from
d0888c2 to
c224d1e
Compare
alexey-tikhonov
added
Accepted
Ready to push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:relnote:Explicit
--with-semanage./configure switch was removed, going forward--with-selinuxincludes this.Resolves: #6647
It was very confusing to have independent
--with-semanageconfigure switch in addition to--with-selinux, at the very least not all combinations were actually supported.