-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Port rootdse test suit to new test framework. #6891
Closed
Closed
+236
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborah-sudo
force-pushed
the
test_rootdse.py
branch
4 times, most recently
from
August 21, 2023 08:52
7b4b316
to
4a81bb7
Compare
madhuriupadhye
requested changes
Aug 30, 2023
aborah-sudo
force-pushed
the
test_rootdse.py
branch
from
August 30, 2023 09:21
4a81bb7
to
8a831be
Compare
aborah-sudo
force-pushed
the
test_rootdse.py
branch
5 times, most recently
from
August 30, 2023 13:36
7d91840
to
f7e4341
Compare
covscan is failing due to an already removed code line. Can you rebase on top of the master branch to get rid of this failure? |
aborah-sudo
force-pushed
the
test_rootdse.py
branch
from
August 31, 2023 13:42
f7e4341
to
07b28a8
Compare
Port rootdse test suit to new test framework.
aborah-sudo
force-pushed
the
test_rootdse.py
branch
from
September 1, 2023 05:47
07b28a8
to
5c75462
Compare
madhuriupadhye
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
shridhargadekar
approved these changes
Sep 14, 2023
aborah-sudo
added
Accepted
Ready to push
Ready to push
and removed
Waiting for review
labels
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port rootdse test suit to new test framework.