Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add sssd_test_framework.markers plugin #6870

Closed
wants to merge 1 commit into from
Closed

tests: add sssd_test_framework.markers plugin #6870

wants to merge 1 commit into from

Conversation

pbrezina
Copy link
Member

This loads additional markers defined in the sssd_test_framework.

Currently, there is only builtwith to check if SSSD was built with
particular feature (files-provider only at this moment).

Depends on:
SSSD/sssd-test-framework#30

@pbrezina
tests: add sssd_test_framework.markers plugin
e5777cd 
This loads additional markers defined in the sssd_test_framework.

Currently, there is only `builtwith` to check if SSSD was built with
particular feature (files-provider only at this moment).
@justin-stephenson
Copy link
Contributor

CI / system fails in the Check Polarian Metadata step. I guess it is expected until this PR is merged?

 Traceback (most recent call last):
  File "/home/runner/work/sssd/sssd/sssd/src/tests/system/.venv/lib/python3.10/site-packages/_pytest/config/__init__.py", line 782, in import_plugin
    __import__(importspec)
ModuleNotFoundError: No module named 'sssd_test_framework.markers'

ikerexxe
ikerexxe approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I tested it locally and it works 😄

@pbrezina
Copy link
Member Author

pbrezina commented Sep 7, 2023

CI / system fails in the Check Polarian Metadata step. I guess it is expected until this PR is merged?

 Traceback (most recent call last):
  File "/home/runner/work/sssd/sssd/sssd/src/tests/system/.venv/lib/python3.10/site-packages/_pytest/config/__init__.py", line 782, in import_plugin
    __import__(importspec)
ModuleNotFoundError: No module named 'sssd_test_framework.markers'

This was waiting for sssd-test-framework PR to be merged. It works now. CI failures are not related.

@pbrezina
Copy link
Member Author

@justin-stephenson ping

justin-stephenson
justin-stephenson approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@justin-stephenson justin-stephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack.

@alexey-tikhonov alexey-tikhonov added the Ready to push Ready to push label Sep 15, 2023
@alexey-tikhonov
Copy link
Member

Pushed PR: #6870

  • master
    • 233a846 - tests: add sssd_test_framework.markers plugin
  • sssd-2-9
    • 71ca205 - tests: add sssd_test_framework.markers plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin-stephenson justin-stephenson justin-stephenson approved these changes

@ikerexxe ikerexxe ikerexxe approved these changes

Assignees

@ikerexxe ikerexxe

@justin-stephenson justin-stephenson

Labels
Pushed Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pbrezina @justin-stephenson @alexey-tikhonov @ikerexxe