Tests: Add following test cases for passkey with LDAP. IPA, AD and Samba #6634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhuriupadhye
force-pushed
the
passkey_tests_part1
branch
from
b7b0da0 to
0c21877
Compare
madhuriupadhye
force-pushed
the
passkey_tests_part1
branch
3 times, most recently
from
12acbda to
97e6184
Compare
ikerexxe
requested changes
Mar 22, 2023
There was a problem hiding this comment.
I checked the first four test cases, and I have added some minor comments. On top of that, would it be possible to reuse the test cases among different servers (IPA, LDAP, AD)? There are minor differences that could be tackled programmatically.
Finally, this is a note for future PRs. It would be nice to divide the changes in several commits. For this PR I would have added one commit to add the changes to the testing framework, and then one commit per test case which could include the scripts. This way you help in the review process by providing small chunks of changes instead of a big commit.
|
By the way, you should check the CI output, as it's reporting some errors to your changes. |
spoore1
reviewed
Mar 22, 2023
pbrezina
requested changes
Mar 23, 2023
madhuriupadhye
force-pushed
the
passkey_tests_part1
branch
3 times, most recently
from
b3dd65f to
d7c9362
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
ikerexxe
requested changes
Apr 3, 2023
spoore1
reviewed
Apr 4, 2023
madhuriupadhye
force-pushed
the
passkey_tests_part1
branch
3 times, most recently
from
b62b143 to
9bdbcdf
Compare
pbrezina
approved these changes
Oct 2, 2023
pbrezina
added
Accepted
Ready to push
madhuriupadhye
added a commit
to madhuriupadhye/sssd
that referenced
this pull request
Nov 23, 2023
Test cases are as follows: 4. Check auth deny for incorrect pin for LDAP, IPA, Ad and Samba. 5. Check auth deny for incorrect passkey mapping for LDAP, IPA, AD and Samba. 6. Check auth of user when server is not resolvable for IPA, LDAP, AD and Samba. First PR is under review, SSSD#6634 Signed-off-by: Madhuri Upadhye <[email protected]>
ikerexxe
pushed a commit
to ikerexxe/sssd
that referenced
this pull request
Nov 23, 2023
Test cases are as follows: 4. Check auth deny for incorrect pin for LDAP, IPA, Ad and Samba. 5. Check auth deny for incorrect passkey mapping for LDAP, IPA, AD and Samba. 6. Check auth of user when server is not resolvable for IPA, LDAP, AD and Samba. First PR is under review, SSSD#6634 Signed-off-by: Madhuri Upadhye <[email protected]>
madhuriupadhye
added a commit
to madhuriupadhye/sssd
that referenced
this pull request
Nov 23, 2023
Test cases are as follows: 4. Check auth deny for incorrect pin for LDAP, IPA, Ad and Samba. 5. Check auth deny for incorrect passkey mapping for LDAP, IPA, AD and Samba. 6. Check auth of user when server is not resolvable for IPA, LDAP, AD and Samba. First PR is under review, SSSD#6634 Signed-off-by: Madhuri Upadhye <[email protected]>
madhuriupadhye
added a commit
to madhuriupadhye/sssd
that referenced
this pull request
Nov 23, 2023
Test cases are as follows: 4. Check auth deny for incorrect pin for LDAP, IPA, Ad and Samba. 5. Check auth deny for incorrect passkey mapping for LDAP, IPA, AD and Samba. 6. Check auth of user when server is not resolvable for IPA, LDAP, AD and Samba. First PR is under review, SSSD#6634 Signed-off-by: Madhuri Upadhye <[email protected]>
madhuriupadhye
added a commit
to madhuriupadhye/sssd
that referenced
this pull request
Nov 23, 2023
Test cases are as follows: 4. Check auth deny for incorrect pin for LDAP, IPA, Ad and Samba. 5. Check auth deny for incorrect passkey mapping for LDAP, IPA, AD and Samba. 6. Check auth of user when server is not resolvable for IPA, LDAP, AD and Samba. First PR is under review, SSSD#6634 Signed-off-by: Madhuri Upadhye <[email protected]>
madhuriupadhye
added a commit
to madhuriupadhye/sssd
that referenced
this pull request
Nov 23, 2023
Test cases are as follows: 4. Check auth deny for incorrect pin for LDAP, IPA, Ad and Samba. 5. Check auth deny for incorrect passkey mapping for LDAP, IPA, AD and Samba. 6. Check auth of user when server is not resolvable for IPA, LDAP, AD and Samba. First PR is under review, SSSD#6634 Signed-off-by: Madhuri Upadhye <[email protected]>
madhuriupadhye
added a commit
to madhuriupadhye/sssd
that referenced
this pull request
Nov 23, 2023
Test cases are as follows: 4. Check auth deny for incorrect pin for LDAP, IPA, Ad and Samba. 5. Check auth deny for incorrect passkey mapping for LDAP, IPA, AD and Samba. 6. Check auth of user when server is not resolvable for IPA, LDAP, AD and Samba. First PR is under review, SSSD#6634 Signed-off-by: Madhuri Upadhye <[email protected]>
madhuriupadhye
added a commit
to madhuriupadhye/sssd
that referenced
this pull request
Nov 23, 2023
Test cases are as follows: 4. Check auth deny for incorrect pin for LDAP, IPA, Ad and Samba. 5. Check auth deny for incorrect passkey mapping for LDAP, IPA, AD and Samba. 6. Check auth of user when server is not resolvable for IPA, LDAP, AD and Samba. First PR is under review, SSSD#6634 Signed-off-by: Madhuri Upadhye <[email protected]>
madhuriupadhye
added a commit
to madhuriupadhye/sssd
that referenced
this pull request
Nov 23, 2023
Test cases are as follows: 4. Check auth deny for incorrect pin for LDAP, IPA, Ad and Samba. 5. Check auth deny for incorrect passkey mapping for LDAP, IPA, AD and Samba. 6. Check auth of user when server is not resolvable for IPA, LDAP, AD and Samba. First PR is under review, SSSD#6634 Signed-off-by: Madhuri Upadhye <[email protected]>
madhuriupadhye
added a commit
to madhuriupadhye/sssd
that referenced
this pull request
Nov 24, 2023
Test cases are as follows: 4. Check auth deny for incorrect pin for LDAP, IPA, Ad and Samba. 5. Check auth deny for incorrect passkey mapping for LDAP, IPA, AD and Samba. 6. Check auth of user when server is not resolvable for IPA, LDAP, AD and Samba. First PR is under review, SSSD#6634 Signed-off-by: Madhuri Upadhye <[email protected]>
madhuriupadhye
added a commit
to madhuriupadhye/sssd
that referenced
this pull request
Nov 24, 2023
Test cases are as follows: 4. Check auth deny for incorrect pin for LDAP, IPA, Ad and Samba. 5. Check auth deny for incorrect passkey mapping for LDAP, IPA, AD and Samba. 6. Check auth of user when server is not resolvable for IPA, LDAP, AD and Samba. First PR is under review, SSSD#6634 Signed-off-by: Madhuri Upadhye <[email protected]>
madhuriupadhye
added a commit
to madhuriupadhye/sssd
that referenced
this pull request
Nov 24, 2023
Test cases are as follows: 4. Check auth deny for incorrect pin for LDAP, IPA, Ad and Samba. 5. Check auth deny for incorrect passkey mapping for LDAP, IPA, AD and Samba. 6. Check auth of user when server is not resolvable for IPA, LDAP, AD and Samba. First PR is under review, SSSD#6634 Signed-off-by: Madhuri Upadhye <[email protected]>
madhuriupadhye
added a commit
to madhuriupadhye/sssd
that referenced
this pull request
Nov 27, 2023
Test cases are as follows: 4. Check auth deny for incorrect pin for LDAP, IPA, Ad and Samba. 5. Check auth deny for incorrect passkey mapping for LDAP, IPA, AD and Samba. 6. Check auth of user when server is not resolvable for IPA, LDAP, AD and Samba. First PR is under review, SSSD#6634 Signed-off-by: Madhuri Upadhye <[email protected]>
madhuriupadhye
added a commit
to madhuriupadhye/sssd
that referenced
this pull request
Nov 27, 2023
Test cases are as follows: 4. Check auth deny for incorrect pin for LDAP, IPA, Ad and Samba. 5. Check auth deny for incorrect passkey mapping for LDAP, IPA, AD and Samba. 6. Check auth of user when server is not resolvable for IPA, LDAP, AD and Samba. First PR is under review, SSSD#6634 Signed-off-by: Madhuri Upadhye <[email protected]>
madhuriupadhye
added a commit
to madhuriupadhye/sssd
that referenced
this pull request
Nov 27, 2023
Test cases are as follows: 4. Check auth deny for incorrect pin for LDAP, IPA, Ad and Samba. 5. Check auth deny for incorrect passkey mapping for LDAP, IPA, AD and Samba. 6. Check auth of user when server is not resolvable for IPA, LDAP, AD and Samba. First PR is under review, SSSD#6634 Signed-off-by: Madhuri Upadhye <[email protected]>
madhuriupadhye
added a commit
to madhuriupadhye/sssd
that referenced
this pull request
Nov 27, 2023
Test cases are as follows: 4. Check auth deny for incorrect pin for LDAP, IPA, Ad and Samba. 5. Check auth deny for incorrect passkey mapping for LDAP, IPA, AD and Samba. 6. Check auth of user when server is not resolvable for IPA, LDAP, AD and Samba. First PR is under review, SSSD#6634 Signed-off-by: Madhuri Upadhye <[email protected]>
madhuriupadhye
added a commit
to madhuriupadhye/sssd
that referenced
this pull request
Nov 27, 2023
Test cases are as follows: 4. Check auth deny for incorrect pin for LDAP, IPA, Ad and Samba. 5. Check auth deny for incorrect passkey mapping for LDAP, IPA, AD and Samba. 6. Check auth of user when server is not resolvable for IPA, LDAP, AD and Samba. First PR is under review, SSSD#6634 Signed-off-by: Madhuri Upadhye <[email protected]>
madhuriupadhye
added a commit
to madhuriupadhye/sssd
that referenced
this pull request
Nov 27, 2023
Test cases are as follows: 4. Check auth deny for incorrect pin for LDAP, IPA, Ad and Samba. 5. Check auth deny for incorrect passkey mapping for LDAP, IPA, AD and Samba. 6. Check auth of user when server is not resolvable for IPA, LDAP, AD and Samba. First PR is under review, SSSD#6634 Signed-off-by: Madhuri Upadhye <[email protected]>
madhuriupadhye
added a commit
to madhuriupadhye/sssd
that referenced
this pull request
Nov 27, 2023
Test cases are as follows: 4. Check auth deny for incorrect pin for LDAP, IPA, Ad and Samba. 5. Check auth deny for incorrect passkey mapping for LDAP, IPA, AD and Samba. 6. Check auth of user when server is not resolvable for IPA, LDAP, AD and Samba. First PR is under review, SSSD#6634 Signed-off-by: Madhuri Upadhye <[email protected]>
madhuriupadhye
added a commit
to madhuriupadhye/sssd
that referenced
this pull request
Nov 28, 2023
Test cases are as follows: 4. Check auth deny for incorrect pin for LDAP, IPA, Ad and Samba. 5. Check auth deny for incorrect passkey mapping for LDAP, IPA, AD and Samba. 6. Check auth of user when server is not resolvable for IPA, LDAP, AD and Samba. First PR is under review, SSSD#6634 Signed-off-by: Madhuri Upadhye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests cases automated with umockdev.