SSSDConfig: use 'setuptools' instead of 'distutils'

[alexey-tikhonov]

The Python standard library distutils module will be removed from Python 3.12+

[alexey-tikhonov]

Simple replacement with setuptools doesn't work for centos8.
Maybe we can just postpone this till centos8 will be backed up by LTS branch only.

[alexey-tikhonov]

@pbrezina, let's remove centos-8 from CI targets for 'master' branch?

[pbrezina]

@pbrezina, let's remove centos-8 from CI targets for 'master' branch?

We can, but... besides this PR, there is nothing that prevents us running tests against c8 and we will still have lots of backports to 2.9. Currently we only run CI on push event for older branches since we do not open pull requests if there is no conflict. I wonder if it would be better to keep running c8 or start require pull requests for backports (can be automated if there is no conflict).

[alexey-tikhonov]

@pbrezina, let's remove centos-8 from CI targets for 'master' branch?

We can, but... besides this PR, there is nothing that prevents us running tests against c8 and we will still have lots of backports to 2.9. Currently we only run CI on push event

Valid point...
Can we condition targets based on backport-to/no-backport labels?

Going forward, we might have more examples where 2.10+ patches won't work on centos-8.

[pbrezina]

@pbrezina, let's remove centos-8 from CI targets for 'master' branch?

We can, but... besides this PR, there is nothing that prevents us running tests against c8 and we will still have lots of backports to 2.9. Currently we only run CI on push event

Valid point... Can we condition targets based on backport-to/no-backport labels?

Going forward, we might have more examples where 2.10+ patches won't work on centos-8.

It won't work, unless it actually uses sssd-2-9 branch to run the test. In other words, we need to move this way, but it is going to be way more complex. We want to have one pull request and if it has backport label then check if there is no conflict and then run PR CI on target distros with backported code.

Or do it (maybe) simple by opening pull request with the backport. Which can be automatically merged, if all checks pass, without review, I think. It's unknown waters. But this is the way that projects on github usually go.

[alexey-tikhonov]

Fail is centos8 specific but manifests only during 'make intgcheck':

Checking .pth file support in /tmp/sssd-intg.bs6XRVwA/lib/python2.7/site-packages/
/usr/bin/python2 -E -c pass
TEST FAILED: /tmp/sssd-intg.bs6XRVwA/lib/python2.7/site-packages/ does NOT support .pth files
error: bad install directory or PYTHONPATH

You are attempting to install a package to a directory that is not
on PYTHONPATH and which Python does not read ".pth" files from.  The
installation directory you specified (via --install-dir, --prefix, or
the distutils default setting) was:

    /tmp/sssd-intg.bs6XRVwA/lib/python2.7/site-packages/

and your PYTHONPATH environment variable currently contains:

    ''

Here are some of your options for correcting the problem:

* You can choose a different installation directory, i.e., one that is
  on PYTHONPATH or supports .pth files

* You can add the installation directory to the PYTHONPATH environment
  variable.  (It must then also be on PYTHONPATH whenever you run
  Python and want to use the package(s) you are installing.)

* You can set up the installation directory to support ".pth" files by
  using one of the approaches described here:

  https://setuptools.readthedocs.io/en/latest/easy_install.html#custom-installation-locations


Please make the appropriate changes for your system and try again.
make[6]: *** [Makefile:47590: install-exec-hook] Error 1

[pbrezina]

I took the liberty to rebase this and added a patch that fixes the centos8 issue, at least locally. Let's see if CI will pass.

[alexey-tikhonov]

I took the liberty to rebase this and added a patch that fixes the centos8 issue, at least locally. Let's see if CI will pass.

I tried something similar (9c65997 and other attempts).
Hope you'll have a better luck.

[pbrezina]

@alexey-tikhonov It's green now. I'm not sure if it is worth it though.

[alexey-tikhonov]

I'm not sure if it is worth it though.

Maybe as a way to postpone solving proper target platform selection...

[justin-stephenson]

Ack, thank you.

[alexey-tikhonov]

ACK

[alexey-tikhonov]

Pushed PR: #6581

• master
  • 61bf109 - SSSDConfig: set PYTHONPATH to make setuptools work on centos8
  • 9efd79b - SSSDConfig: use 'setuptools' instead of 'distutils'