Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TROUBLESHOOTING: Performance tuning in sssd #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

TROUBLESHOOTING: Performance tuning in sssd #73

wants to merge 1 commit into from

Conversation

Roy214
Copy link
Contributor

@Roy214 Roy214 commented Aug 21, 2023 •
edited
Loading

This page will describe the performance-related issues in sssd and how to troubleshoot those issues.

@Roy214 Roy214 marked this pull request as draft August 21, 2023 22:26
ikerexxe
ikerexxe requested changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the minor comment, you should also add the link to the new file to the Troubleshooting section of the contents.rst file:

Performance <troubleshooting/performance>

src/troubleshooting/performance.rst Outdated Show resolved Hide resolved
@Roy214 Roy214 force-pushed the perfm branch 4 times, most recently from 3976331 to 7122b97 Compare August 22, 2023 21:04
@ikerexxe
Copy link
Contributor

CI continues failing. After digging a little bit I've opened jdillard/sphinx-gitstamp#15

@Roy214
Copy link
Contributor Author

Roy214 commented Aug 23, 2023

jdillard/sphinx-gitstamp#15

@ikerexxe I was trying to figure out why the CI was failing. Thank you for identifying the issue.

@ikerexxe
Copy link
Contributor

@Roy214 I think the problem is fixed, but I don't know how to retrigger the failing check workflow. Can you push your branch after some changes to be sure?

@Roy214
Copy link
Contributor Author

Roy214 commented Aug 24, 2023

@Roy214 I think the problem is fixed, but I don't know how to retrigger the failing check workflow. Can you push your branch after some changes to be sure?

@ikerexxe All checks have passed thank you.

@Roy214 Roy214 force-pushed the perfm branch 6 times, most recently from e2b8ae7 to 43870ce Compare August 24, 2023 23:01
@Roy214 Roy214 marked this pull request as ready for review August 25, 2023 11:38
@Roy214
Copy link
Contributor Author

Roy214 commented Aug 25, 2023

@ikerexxe @alexey-tikhonov @pbrezina I am keeping this PR Waiting on Review if you can have a look as per bwd. Once this is done I will start with high CPU/memory consumption in sssd.

@ikerexxe ikerexxe added the Waiting for review Pull request is awaiting review label Aug 29, 2023
@Roy214 Roy214 force-pushed the perfm branch 2 times, most recently from 8508ed2 to 2dc140b Compare August 30, 2023 21:43
alexey-tikhonov
alexey-tikhonov reviewed Sep 13, 2023
View reviewed changes
src/contents.rst Outdated Show resolved Hide resolved
@Roy214 Roy214 force-pushed the perfm branch 4 times, most recently from 83b6e94 to 6232fec Compare September 13, 2023 18:01
@justin-stephenson justin-stephenson self-assigned this Sep 13, 2023
@andreboscatto andreboscatto added Changes requested Pull request requires changes and removed Waiting for review Pull request is awaiting review labels Sep 26, 2023
@Roy214 Roy214 force-pushed the perfm branch 2 times, most recently from 0d0858d to c56525e Compare September 27, 2023 17:47
@alexey-tikhonov alexey-tikhonov added Waiting for review Pull request is awaiting review and removed Changes requested Pull request requires changes labels Oct 9, 2023
@Roy214
Copy link
Contributor Author

Roy214 commented Oct 13, 2023

@alexey-tikhonov Do you have any further suggestions on slow ssh and slow id lookup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-tikhonov alexey-tikhonov alexey-tikhonov left review comments

@ikerexxe ikerexxe ikerexxe requested changes

@justin-stephenson justin-stephenson justin-stephenson approved these changes

@sumit-bose sumit-bose Awaiting requested review from sumit-bose

Requested changes must be addressed to merge this pull request.

Assignees

@justin-stephenson justin-stephenson

@sumit-bose sumit-bose

@alexey-tikhonov alexey-tikhonov

Labels
Waiting for review Pull request is awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Roy214 @ikerexxe @justin-stephenson @alexey-tikhonov @andreboscatto @sumit-bose