Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix dnf5 issues and add passlib #99

Merged
merged 3 commits into from
Jun 7, 2024
Merged

ci: Fix dnf5 issues and add passlib #99

merged 3 commits into from
Jun 7, 2024

Conversation

jakub-vavra-cz
Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz commented Jun 3, 2024 •
edited
Loading

@jakub-vavra-cz jakub-vavra-cz force-pushed the dnf5 branch 15 times, most recently from dddbbf9 to 3d06f48 Compare June 5, 2024 10:37
@pbrezina pbrezina mentioned this pull request Jun 5, 2024
Closed
@jakub-vavra-cz jakub-vavra-cz requested a review from pbrezina June 5, 2024 12:40
@jakub-vavra-cz jakub-vavra-cz marked this pull request as ready for review June 5, 2024 12:40
@jakub-vavra-cz jakub-vavra-cz changed the title ci: Fix dnf5 ci: Fix dnf5 issues and add passlib Jun 5, 2024
@jakub-vavra-cz jakub-vavra-cz force-pushed the dnf5 branch 5 times, most recently from 5d25dea to 88ab11b Compare June 6, 2024 10:57
@jakub-vavra-cz jakub-vavra-cz marked this pull request as draft June 6, 2024 10:57
@jakub-vavra-cz jakub-vavra-cz marked this pull request as ready for review June 6, 2024 11:18
@jakub-vavra-cz jakub-vavra-cz removed the request for review from pbrezina June 6, 2024 11:25
@jakub-vavra-cz
provision: Fix dnf5 incompatibilities
d7e191d 
Dnf5 has some incompatibilities like missing sub-commands and aliases.
It also seems to have some regression between ansible dnf5 that
breaks * wildcard (ansible/ansible#83373).
@jakub-vavra-cz
ci: Print ansible version info.
259a8b4
@andreboscatto andreboscatto requested a review from ikerexxe June 6, 2024 12:51
ikerexxe
ikerexxe reviewed Jun 6, 2024
View reviewed changes
Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several comments inline

.github/actions/install-dependencies/action.yml Show resolved Hide resolved
src/ansible/roles/packages/tasks/Fedora.yml Show resolved Hide resolved
src/ansible/roles/packages/tasks/Fedora.yml Show resolved Hide resolved
@jakub-vavra-cz jakub-vavra-cz requested a review from ikerexxe June 6, 2024 18:41
ikerexxe
ikerexxe approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

There's a pending conversation, but that's to satisfy my curiosity and it shouldn't block this PR moving forward.

@jakub-vavra-cz jakub-vavra-cz merged commit f93a5da into SSSD:master Jun 7, 2024
10 of 11 checks passed
@jakub-vavra-cz jakub-vavra-cz deleted the dnf5 branch November 11, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikerexxe ikerexxe ikerexxe approved these changes

Assignees

@ikerexxe ikerexxe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakub-vavra-cz @ikerexxe