Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: centralize iam role setup for github actions #4

Merged
merged 1 commit into from
Oct 30, 2024
Merged

feat: centralize iam role setup for github actions #4

merged 1 commit into from
Oct 30, 2024

Conversation

jboix
Copy link
Contributor

@jboix jboix commented Oct 28, 2024

Description

Centralizes all IAM role setups for GitHub in a single terraform project.

Changes Made

  • Added a new Terraform project to centralize IAM role configurations for GitHub Actions.
  • Migrated IAM role setup from ECR configuration into this project.
  • Expanded permissions to allow GitHub Actions to update ECS services in both prod and dev.

Checklist

  • I have followed the project's style and contribution guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.

@jboix jboix self-assigned this Oct 28, 2024
@jboix jboix requested a review from MGaetan89 October 28, 2024 15:43
@jboix
feat: centralize iam role setup for github actions
75d06fa 
- Added a new Terraform project to centralize IAM role configurations for GitHub Actions.
- Migrated IAM role setup from ECR configuration into this project.
- Expanded permissions to allow GitHub Actions to update ECS services in both prod and dev.
@jboix jboix changed the title feat: centralize iam role setup for gitHub actions feat: centralize iam role setup for github actions Oct 28, 2024
@jboix jboix added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 9010fcc Oct 30, 2024
1 check passed
@jboix jboix deleted the feat/github-iam-roles branch November 28, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Assignees

@jboix jboix

Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jboix @MGaetan89