Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

802 player time api #814

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
/*
* Copyright (c) SRG SSR. All rights reserved.
* License information is available from the LICENSE file.
*/
package ch.srgssr.pillarbox.demo.shared.ui

import kotlinx.datetime.LocalTime
import kotlinx.datetime.format.Padding
import kotlinx.datetime.format.char

/**
* Local time formatter that format [LocalTime] to HH:mm:ss.
*/
val localTimeFormatter by lazy {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update CountdownView to use this formatter, since it defined its own with the same configuration?

LocalTime.Format {
hour(Padding.ZERO)
char(':')
minute(Padding.ZERO)
char(':')
second(Padding.ZERO)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -80,4 +80,7 @@ sealed interface NavigationRoutes {

@Serializable
data object ThumbnailShowcase : NavigationRoutes

@Serializable
data object TimeBasedContent : NavigationRoutes
}
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ import ch.srgssr.pillarbox.demo.shared.R
import ch.srgssr.pillarbox.demo.shared.extension.onDpadEvent
import ch.srgssr.pillarbox.demo.shared.ui.components.PillarboxSlider
import ch.srgssr.pillarbox.demo.shared.ui.getFormatter
import ch.srgssr.pillarbox.demo.shared.ui.localTimeFormatter
import ch.srgssr.pillarbox.demo.shared.ui.player.metrics.MetricsOverlay
import ch.srgssr.pillarbox.demo.shared.ui.settings.MetricsOverlayOptions
import ch.srgssr.pillarbox.demo.tv.ui.player.compose.controls.PlayerError
Expand All @@ -60,19 +61,24 @@ import ch.srgssr.pillarbox.demo.tv.ui.theme.paddings
import ch.srgssr.pillarbox.player.PillarboxExoPlayer
import ch.srgssr.pillarbox.player.currentPositionAsFlow
import ch.srgssr.pillarbox.player.extension.canSeek
import ch.srgssr.pillarbox.player.extension.getUnixTimeMs
import ch.srgssr.pillarbox.ui.extension.availableCommandsAsState
import ch.srgssr.pillarbox.ui.extension.currentMediaMetadataAsState
import ch.srgssr.pillarbox.ui.extension.currentPositionAsState
import ch.srgssr.pillarbox.ui.extension.durationAsState
import ch.srgssr.pillarbox.ui.extension.getCurrentChapterAsState
import ch.srgssr.pillarbox.ui.extension.getCurrentCreditAsState
import ch.srgssr.pillarbox.ui.extension.isCurrentMediaItemLiveAsState
import ch.srgssr.pillarbox.ui.extension.playerErrorAsState
import ch.srgssr.pillarbox.ui.widget.DelayedVisibilityState
import ch.srgssr.pillarbox.ui.widget.maintainVisibleOnFocus
import ch.srgssr.pillarbox.ui.widget.player.PlayerSurface
import ch.srgssr.pillarbox.ui.widget.rememberDelayedVisibilityState
import kotlinx.coroutines.delay
import kotlinx.coroutines.flow.map
import kotlinx.datetime.Instant
import kotlinx.datetime.TimeZone
import kotlinx.datetime.toLocalDateTime
import kotlin.time.Duration.Companion.ZERO
import kotlin.time.Duration.Companion.milliseconds
import kotlin.time.Duration.Companion.seconds
Expand Down Expand Up @@ -306,9 +312,19 @@ private fun PlayerTimeRow(
var compactMode by remember {
mutableStateOf(true)
}
val isLive by player.isCurrentMediaItemLiveAsState()
val positionTime = if (isLive) player.getUnixTimeMs(positionMs) else C.TIME_UNSET
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we pass a Window to getUnixTimeMs()?

val positionLabel = when (positionTime) {
C.TIME_UNSET -> formatter(positionMs.milliseconds)

else -> {
val localTime = Instant.fromEpochMilliseconds(positionTime).toLocalDateTime(TimeZone.currentSystemDefault()).time
localTimeFormatter.format(localTime)
}
}

Text(
text = "${formatter(positionMs.milliseconds)} / ${formatter(duration)}",
text = "$positionLabel / ${formatter(duration)}",
modifier = Modifier.padding(
top = MaterialTheme.paddings.baseline,
bottom = MaterialTheme.paddings.small,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,25 @@ import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.media3.common.C
import androidx.media3.common.Player
import androidx.media3.common.Timeline.Window
import ch.srgssr.pillarbox.demo.shared.ui.components.PillarboxSlider
import ch.srgssr.pillarbox.demo.shared.ui.getFormatter
import ch.srgssr.pillarbox.demo.shared.ui.localTimeFormatter
import ch.srgssr.pillarbox.demo.ui.theme.paddings
import ch.srgssr.pillarbox.player.PillarboxExoPlayer
import ch.srgssr.pillarbox.player.extension.canSeek
import ch.srgssr.pillarbox.player.extension.getUnixTimeMs
import ch.srgssr.pillarbox.ui.ProgressTrackerState
import ch.srgssr.pillarbox.ui.SimpleProgressTrackerState
import ch.srgssr.pillarbox.ui.SmoothProgressTrackerState
import ch.srgssr.pillarbox.ui.extension.availableCommandsAsState
import ch.srgssr.pillarbox.ui.extension.currentBufferedPercentageAsState
import ch.srgssr.pillarbox.ui.extension.durationAsState
import ch.srgssr.pillarbox.ui.extension.isCurrentMediaItemLiveAsState
import kotlinx.coroutines.CoroutineScope
import kotlinx.datetime.Instant
import kotlinx.datetime.TimeZone
import kotlinx.datetime.toLocalDateTime
import kotlin.time.Duration.Companion.ZERO
import kotlin.time.Duration.Companion.milliseconds

Expand Down Expand Up @@ -76,6 +83,7 @@ fun PlayerTimeSlider(
progressTracker: ProgressTrackerState = rememberProgressTrackerState(player = player, smoothTracker = true),
interactionSource: MutableInteractionSource? = null,
) {
val window = remember { Window() }
val rememberedProgressTracker by rememberUpdatedState(progressTracker)
val durationMs by player.durationAsState()
val duration = remember(durationMs) {
Expand All @@ -95,7 +103,20 @@ fun PlayerTimeSlider(
verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.spacedBy(MaterialTheme.paddings.mini)
) {
Text(text = formatter(currentProgress), color = Color.White)
val isLive by player.isCurrentMediaItemLiveAsState()
val timePosition = if (isLive) player.getUnixTimeMs(currentProgress.inWholeMilliseconds, window) else C.TIME_UNSET
// We choose to display local time only when it is live, but it is possible to have timestamp inside VoD.
val positionLabel =
when (timePosition) {
C.TIME_UNSET -> formatter(currentProgress)

else -> {
val localTime = Instant.fromEpochMilliseconds(timePosition).toLocalDateTime(TimeZone.currentSystemDefault()).time
localTimeFormatter.format(localTime)
}
}

Text(text = positionLabel, color = Color.White)

PillarboxSlider(
value = currentProgressPercent,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,14 @@ fun ShowcasesHome(navController: NavController) {

HorizontalDivider()

DemoListItemView(
title = stringResource(R.string.showcase_time_based_content),
modifier = itemModifier,
onClick = { navController.navigate(NavigationRoutes.TimeBasedContent) }
)

HorizontalDivider()

DemoListItemView(
title = stringResource(R.string.adaptive),
modifier = itemModifier,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import ch.srgssr.pillarbox.demo.ui.showcases.misc.ResizablePlayerShowcase
import ch.srgssr.pillarbox.demo.ui.showcases.misc.SmoothSeekingShowcase
import ch.srgssr.pillarbox.demo.ui.showcases.misc.SphericalSurfaceShowcase
import ch.srgssr.pillarbox.demo.ui.showcases.misc.StartAtGivenTimeShowcase
import ch.srgssr.pillarbox.demo.ui.showcases.misc.TimeBasedContent
import ch.srgssr.pillarbox.demo.ui.showcases.misc.TrackingToggleShowcase
import ch.srgssr.pillarbox.demo.ui.showcases.misc.UpdatableMediaItemShowcase
import ch.srgssr.pillarbox.demo.ui.showcases.playlists.CustomPlaybackSettingsShowcase
Expand Down Expand Up @@ -74,6 +75,9 @@ fun NavGraphBuilder.showcasesNavGraph(navController: NavController) {
composable<NavigationRoutes.ThumbnailShowcase>(DemoPageView("ThumbnailShowcase", Levels)) {
ThumbnailView()
}
composable<NavigationRoutes.TimeBasedContent>(DemoPageView("TimeBasedContent", Levels)) {
TimeBasedContent()
}
}

private val Levels = listOf("app", "pillarbox", "showcase")
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
/*
* Copyright (c) SRG SSR. All rights reserved.
* License information is available from the LICENSE file.
*/
package ch.srgssr.pillarbox.demo.ui.showcases.misc

import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.lazy.LazyColumn
import androidx.compose.material3.HorizontalDivider
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.minimumInteractiveComponentSize
import androidx.compose.runtime.Composable
import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.getValue
import androidx.compose.ui.Modifier
import androidx.lifecycle.compose.collectAsStateWithLifecycle
import androidx.lifecycle.viewmodel.compose.viewModel
import ch.srgssr.pillarbox.demo.ui.components.DemoListHeaderView
import ch.srgssr.pillarbox.demo.ui.components.DemoListItemView
import ch.srgssr.pillarbox.demo.ui.components.DemoListSectionView
import ch.srgssr.pillarbox.demo.ui.player.DemoPlayerView
import ch.srgssr.pillarbox.demo.ui.theme.paddings
import ch.srgssr.pillarbox.player.extension.seekToUnixTimeMs
import kotlinx.datetime.Clock

/**
* Time-based content that demonstrates how to use timestamp-based api.
*/
@Composable
fun TimeBasedContent() {
val viewModel: TimeBasedContentViewModel = viewModel()
val player = viewModel.player
val timedEvents by viewModel.deltaTimeEvents.collectAsStateWithLifecycle()

LaunchedEffect(player) {
player.play()
}
Comment on lines +38 to +40
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use a LifecycleEffect here?

Copy link
Contributor Author

@StaehliJ StaehliJ Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because la flemme. But for sure we should play/pause player with lifecyle.

Column {
DemoPlayerView(player = player, modifier = Modifier.weight(1f))
LazyColumn(
modifier = Modifier
.padding(horizontal = MaterialTheme.paddings.baseline)
.weight(1f),
verticalArrangement = Arrangement.spacedBy(MaterialTheme.paddings.small)
) {
item {
DemoListHeaderView("Timed events")
}
item {
DemoListSectionView {
timedEvents.forEachIndexed { index, timedEvent ->
DemoListItemView(
title = timedEvent.name,
subtitle = "Delta time ${timedEvent.delta}",
modifier = Modifier
.fillMaxWidth()
.minimumInteractiveComponentSize()
) {
val now = Clock.System.now()
player.seekToUnixTimeMs((now + timedEvent.delta).toEpochMilliseconds())
}

if (index < timedEvents.lastIndex) {
HorizontalDivider()
}
}
}
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
/*
* Copyright (c) SRG SSR. All rights reserved.
* License information is available from the LICENSE file.
*/
package ch.srgssr.pillarbox.demo.ui.showcases.misc

import android.app.Application
import androidx.lifecycle.AndroidViewModel
import androidx.lifecycle.viewModelScope
import ch.srgssr.pillarbox.core.business.PillarboxExoPlayer
import ch.srgssr.pillarbox.demo.shared.data.DemoItem
import kotlinx.coroutines.flow.SharingStarted
import kotlinx.coroutines.flow.StateFlow
import kotlinx.coroutines.flow.flow
import kotlinx.coroutines.flow.stateIn
import kotlin.time.Duration
import kotlin.time.Duration.Companion.hours
import kotlin.time.Duration.Companion.seconds

/**
* A view model that exposes some timed events.
*
* @param application The [Application].
*/
class TimeBasedContentViewModel(application: Application) : AndroidViewModel(application) {

/**
* Player
*/
val player = PillarboxExoPlayer(application)

/**
* Timed events
*/
val deltaTimeEvents: StateFlow<List<DeltaTimeEvent>> = flow {
emit(
listOf(
DeltaTimeEvent(name = "Now", Duration.ZERO),
DeltaTimeEvent(name = "2 hours in the past", (-2).hours),
DeltaTimeEvent(name = "1 hour in the past", (-1).hours),
DeltaTimeEvent(name = "Near future", 30.seconds),
DeltaTimeEvent(name = "In 1 hour", 1.hours),
DeltaTimeEvent(name = "4 hours in the past", (-4).hours),
)
)
}.stateIn(viewModelScope, SharingStarted.Lazily, emptyList())

init {
player.setMediaItem(DemoItem.LiveTimestampVideoHLS.toMediaItem())
player.prepare()
}

override fun onCleared() {
player.release()
}

/**
* @property name Name of the event.
* @property delta The delta [Duration] of the event from now.
*/
data class DeltaTimeEvent(
val name: String,
val delta: Duration,
)
}
1 change: 1 addition & 0 deletions pillarbox-demo/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,5 @@
<string name="settings_enabled_overlay_description">Display an overlay on top of the video surface to show useful information.</string>
<string name="settings_enabled_metrics_overlay">Enable metrics overlay</string>
<string name="showcase_countdown">Content always not yet available</string>
<string name="showcase_time_based_content">Content with timestamps</string>
</resources>
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
* Copyright (c) SRG SSR. All rights reserved.
* License information is available from the LICENSE file.
*/
@file:Suppress("TooManyFunctions")

package ch.srgssr.pillarbox.player.extension

import androidx.media3.common.C
Expand Down Expand Up @@ -118,22 +120,35 @@ fun Player.isAtLiveEdge(positionMs: Long = currentPosition, window: Window = Win
}

/**
* Get the player's position timestamp of the media being played, or `null` if not available.
*
* @param window A reusable [Window] instance.
* Calculates the unix time corresponding to the given position in the current media item in milliseconds.
*
* @return The player's position timestamp of the media being played, in milliseconds, or `null` if not available.
* @param positionMs The position in milliseconds within the current media item. Defaults to the current playback position.
* @param window A [Window] object to store the window information. A new instance will be created if not provided.
* @return The unix time corresponding to the given position, or [C.TIME_UNSET] if the timeline is empty or the window start time is unset.
*/
internal fun Player.getPositionTimestamp(window: Window = Window()): Long? {
if (currentTimeline.isEmpty) {
return null
}

@Suppress("ReturnCount")
fun Player.getUnixTimeMs(positionMs: Long = currentPosition, window: Window = Window()): Long {
if (currentTimeline.isEmpty) return C.TIME_UNSET
currentTimeline.getWindow(currentMediaItemIndex, window)
if (window.windowStartTimeMs == C.TIME_UNSET) return C.TIME_UNSET
return window.windowStartTimeMs + if (positionMs != C.TIME_UNSET) positionMs else window.durationMs
}

return if (window.elapsedRealtimeEpochOffsetMs != C.TIME_UNSET) {
window.windowStartTimeMs + currentPosition
} else {
null
/**
* Seeks the player to the specified unix time in milliseconds within the current media item's window.
*
* This function calculates the seek position relative to the window's start time
* and uses it to seek the player. If the provided unix time or the window's start time
* is unset ([C.TIME_UNSET]), or if the current timeline is empty, the function does nothing.
*
* @param unixTimeMs The target unix time to seek to, in milliseconds.
* @param window A [Window] object to store the current window information.
* If not provided, a new [Window] object will be created.
*/
fun Player.seekToUnixTimeMs(unixTimeMs: Long, window: Window = Window()) {
if (unixTimeMs == C.TIME_UNSET || currentTimeline.isEmpty) return
currentTimeline.getWindow(currentMediaItemIndex, window)
if (window.windowStartTimeMs != C.TIME_UNSET) {
seekTo(unixTimeMs - window.windowStartTimeMs)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@
*/
package ch.srgssr.pillarbox.player.monitoring.models

import androidx.media3.common.C
import androidx.media3.common.Player
import ch.srgssr.pillarbox.player.extension.getPositionTimestamp
import ch.srgssr.pillarbox.player.extension.getUnixTimeMs
import kotlinx.serialization.SerialName
import kotlinx.serialization.Serializable

Expand Down Expand Up @@ -40,7 +41,7 @@ data class ErrorMessageData(
message = throwable.message.orEmpty(),
name = throwable::class.simpleName.orEmpty(),
position = player.currentPosition,
positionTimestamp = player.getPositionTimestamp(),
positionTimestamp = player.getUnixTimeMs().takeIf { it != C.TIME_UNSET },
url = url,
)
}
Loading