Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t5 - User is able to update availability from Staff Tab #164

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

Julian88Tex
Copy link
Contributor

@Julian88Tex Julian88Tex commented May 18, 2020

Critical Changes

Changes

  • Create an automated UI test which verifies availability records can properly be changed on Staff page of Community
  • Refactored t1 test some to work with new create_community_users robot task that's part of a org setup

Issues Closed

@Julian88Tex
Copy link
Contributor Author

@skristem this is ready for review


User Updates Availibility From Staff Tab
Login To Community As Resident
Locate John Done On Staff Page
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of hard coding, Please change the keywords to be more flexible and reusable considering we may encounter similar step. Like "Locate Staff. " where you are passing a variable and later I can use it in my test too with a different variable

Login To Community As Resident
Locate John Done On Staff Page
Set 1st Availibility To Not Available
Verify 1st Availibility Is Not Available
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing " Verify Availability. 1. Available " when you do that in the next usage you can say
Verify Availability 2. NotAvailable.
Same keyword but the parameters are changing

Comment on lines +17 to +20
Click Element //*/a[@title="Select List View"]
Click Element //*[contains(text(), "Detailed Staff List")]
Wait Until Element Is Visible //*/a[@title="Aarika Mewhirter"]
Press Keys //*/input[@name="Contact-search-input"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please place the elements in the relevant locators.py

Copy link
Collaborator

@rjanjanam rjanjanam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the locators to locators.py and try to place in reusable keywords that take in a set of arguments

@salesforce-cla
Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Julian Joseph <j***@j***.i***.s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:missing test test automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants