Fix edge refinement #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
JPPayonk
commented
Jul 25, 2024
JPPayonk
commented
- fix edge refinement and naming
- add an example to MeshAPI
- label only the outer edges of the contact
j-zimmermann
requested changes
Jul 25, 2024
There was a problem hiding this comment.
I think your code makes sense so far but I actually found a bigger problem looking at it.
Since the contacts are oriented before (!) the edge names are assigned, I would expect weird behaviour for all electrodes that not oriented in z-direction (0, 0, 1).
I tested this locally for the Vercise (not directed).
I see two possible options: either always consider the orientation when finding the contacts or having an unoriented base contact that later gets oriented.
… into fix_edge_refinement
* update wire for microprobes electrode --------- Co-authored-by: JPPayonk <[email protected]>
… into fix_edge_refinement
j-zimmermann
approved these changes
Nov 5, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.