Run CI Tests on Windows #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexcojocaru2002 Regarding #218: Did it turn out there was no bug after all? Does the temp directory get properly deleted? |
I think the bug fixed itself with the new additions to the workflow files... I can't see the logs anymore so I am not sure which temporary file it was, but I would assume yes since the actions are running fine. |
|
OK, I'll close the issue then. Thanks! |
martinmladenov
approved these changes
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #218.
Closes #253.
The aim of this PR is to add windows as an OS option when running the CI and to fix it in case the previous errors are still existent.