Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up technical debt #123

Merged
merged 7 commits into from
Apr 2, 2024
Merged

Clean up technical debt #123

merged 7 commits into from
Apr 2, 2024

Conversation

pebenito
Copy link
Member

@pebenito pebenito commented Apr 2, 2024 •
edited
Loading

Various cleanups and code quality improvements:

  • Convert format strings to f-strings.
  • Extensively add type annotations.
  • Update existing type annotations to use Python 3.0 style, e.g. Union[A,B] -> A | B
  • Remove tuple compat from sediff dataclasses, update sediff accordingly.
  • Remove most variable reuse in sediff.
  • Improve descriptors in diff classes

pebenito added 7 commits April 2, 2024 15:36
@pebenito
Replace str.format() with f-strings.
244cd81 
Signed-off-by: Chris PeBenito <[email protected]>
@pebenito
sediff: Update for dataclass use in modified rules.
3e3538f 
Signed-off-by: Chris PeBenito <[email protected]>
@pebenito
Extensively add type annotations.
ecb76d4 
Thoroughly go through the entire setools package and add type annotations.

Signed-off-by: Chris PeBenito <[email protected]>
@pebenito
policyrep: Convert remaining named tuples to dataclasses.
8581131 
Signed-off-by: Chris PeBenito <[email protected]>
@pebenito
sediff: Remove most variable reuse.
79bda26 
The variable reuse makes typing very messy. Remove most reuses to clean it up.

Signed-off-by: Chris PeBenito <[email protected]>
@pebenito
TERulesDifference: Change closures to use TERuletype directly.
1d6861d 
The lookup is unnecessary, since these calls are static.

Signed-off-by: Chris PeBenito <[email protected]>
@pebenito
DiffResultDescriptor: Use the diff function directly.
8cb28fc 
Don't indirectly specify the function by name.

Signed-off-by: Chris PeBenito <[email protected]>
@pebenito pebenito merged commit 4c205e4 into SELinuxProject:main Apr 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pebenito