Fix PyPackageDir #4479
Merged
Fix PyPackageDir #4479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing a module which the active Python (system or virtualenv) cannot locate through the import machinery would cause SCons to fail with an AttributError, because the result of the initial lookup was used without checking for success. Now returns None for not found. Manpage entry and docstring also updated. Signed-off-by: Mats Wichmann <[email protected]>
mwichmann
force-pushed
the
doc/PyPackageDir
branch
from
7e84cc5 to
00ef03a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing a module to
PyPackageDirwhich the active Python (system or virtualenv) cannot locate through the import machinery would cause SCons to fail with anAttributError, because the result of the initial lookup was used without checking for success. Now returnsNonefor not found. Manpage entry and docstring also updated.Contributor Checklist:
CHANGES.txt(and read theREADME.rst)